From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Markus Armbruster References: <20221121140121.1079100-1-armbru@redhat.com> <7875a42b-2776-9d36-5373-78ac75cff89d@linaro.org> Date: Mon, 21 Nov 2022 17:32:12 +0100 In-Reply-To: <7875a42b-2776-9d36-5373-78ac75cff89d@linaro.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Mon, 21 Nov 2022 17:03:50 +0100") Message-ID: <87a64ki7zn.fsf@pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Virtio-fs] [PATCH] cleanup: Tweak and re-run return_directly.cocci List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Peter Maydell , qemu-devel@nongnu.org, fam@euphon.net, kwolf@redhat.com, hreitz@redhat.com, groug@kaod.org, qemu_oss@crudebyte.com, Alistair.Francis@wdc.com, bin.meng@windriver.com, palmer@dabbelt.com, marcandre.lureau@redhat.com, pbonzini@redhat.com, yuval.shaia.ml@gmail.com, marcel.apfelbaum@gmail.com, mst@redhat.com, quintela@redhat.com, dgilbert@redhat.com, pavel.dovgaluk@ispras.ru, alex.bennee@linaro.org, peterx@redhat.com, david@redhat.com, mrolnik@gmail.com, gaosong@loongson.cn, yangxiaojuan@loongson.cn, aurelien@aurel32.net, jiaxun.yang@flygoat.com, aleksandar.rikalo@syrmia.com, jcmvbkbc@gmail.com, berrange@redhat.com, thuth@redhat.com, lvivier@redhat.com, suhang16@mails.ucas.ac.cn, chen.zhang@intel.com, lizhijian@fujitsu.com, stefanha@redhat.com, qemu-block@nongnu.org, qemu-riscv@nongnu.org, qemu-ppc@nongnu.org, virtio-fs@redhat.com Philippe Mathieu-Daud=C3=A9 writes: > On 21/11/22 15:36, Peter Maydell wrote: >> On Mon, 21 Nov 2022 at 14:03, Markus Armbruster wrot= e: >>> >>> Tweak the semantic patch to drop redundant parenthesis around the >>> return expression. >>> >>> Coccinelle drops comments in hw/rdma/vmw/pvrdma_cmd.c; restored >>> manually. >>> >>> Coccinelle messes up vmdk_co_create(), not sure why. Transformed >>> manually. >>> >>> Line breaks in target/avr/cpu.h and hw/rdma/vmw/pvrdma_cmd.c tidied up >>> manually. >>> >>> Whitespace in fuse_reply_iov() tidied up manually. >>> >>> checkpatch.pl complains "return of an errno should typically be -ve" >>> two times for hw/9pfs/9p-synth.c. Preexisting, the patch merely makes >>> it visible to checkpatch.pl. >>> >>> checkpatch.pl complains "return is not a function, parentheses are not >>> required" three times for target/mips/tcg/dsp_helper.c. False >>> positives. >>> >>> Signed-off-by: Markus Armbruster >>=20 >>> .../user/ase/msa/bit-count/test_msa_nloc_b.c | 9 +- >>> .../user/ase/msa/bit-count/test_msa_nloc_d.c | 9 +- >> [snip long list of other mips test files] >>=20 >>> 328 files changed, 989 insertions(+), 2099 deletions(-) >> This patch seems to almost entirely be huge because of these >> mips test case files. Are they specific to QEMU or are they >> effectively a 3rd-party import that it doesn't make sense >> to make local changes to? > > They are imported and will unlikely be modified. Not obvious to me from git-log. Should I drop the changes to tests/tcg/mips/?