From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=bS1IB1XREnR8KmNVOEsfM22GWkyOJKUf+hw6J5zm4ok=; b=Z7lFb7b5chra99nGUi3FCKu7WihvArwjmD8LaiEePzrzusJZCipb5hIIY9JtDbk2oP FHAFntpmdPrUZXhnBwrjybNN9XIo2082CTAKa6S5boANzyOZB9T3l+NZIJCXI9H5BGi5 eEXtCiYjj3fr3rvz5UvLhf8be9iNt2Vsym/VLjn4vbuD64sy4RKq+LsK5SnFYm1BKRzG cqrgwuy7xw7p/+VBtn7atBh1bn/QE/g9fOo8TjtD7Bk7yFPYIwElJcQz1YHj04Gu2M67 4GsqC2Vo81+KBF4+5vKx7L1T59wawAeqzAgqkkjUmp6D3DiHr6mzOyCpOxzbyTSEB6bP 2Iqw== References: <20221010172813.204597-1-mst@redhat.com> <20221010172813.204597-8-mst@redhat.com> <3a002a6a-9135-ad45-3fed-7dd270450d0b@linux.ibm.com> <1c400131-59f6-f14f-e7e0-3871cc0d1815@linux.ibm.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= Date: Fri, 14 Oct 2022 12:07:17 +0100 In-reply-to: <1c400131-59f6-f14f-e7e0-3871cc0d1815@linux.ibm.com> Message-ID: <87czauoe6y.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 Subject: Re: [Virtio-fs] Regression save/restore of vsock: (was [PULL 07/55] hw/virtio: move vm_running check to virtio_device_started) List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, Peter Maydell , "Dr. David Alan Gilbert" , Stefan Hajnoczi , Mathieu Poirier , virtio-fs@redhat.com DQpDaHJpc3RpYW4gQm9ybnRyYWVnZXIgPGJvcm50cmFlZ2VyQGxpbnV4LmlibS5jb20+IHdyaXRl czoNCg0KPiBBbSAxNC4xMC4yMiB1bSAwOTozMCBzY2hyaWViIENocmlzdGlhbiBCb3JudHJhZWdl cjoNCj4+IEFtIDEwLjEwLjIyIHVtIDE5OjI5IHNjaHJpZWIgTWljaGFlbCBTLiBUc2lya2luOg0K Pj4+IEZyb206IEFsZXggQmVubsOpZSA8YWxleC5iZW5uZWVAbGluYXJvLm9yZz4NCj4+Pg0KPj4+ IEFsbCB0aGUgYm9pbGVycGxhdGUgdmlydGlvIGNvZGUgZG9lcyB0aGUgc2FtZSB0aGluZyAob3Ig c2hvdWxkIGF0DQo+Pj4gbGVhc3QpIG9mIGNoZWNraW5nIHRvIHNlZSBpZiB0aGUgVk0gaXMgcnVu bmluZyBiZWZvcmUgYXR0ZW1wdGluZyB0bw0KPj4+IHN0YXJ0IFZpcnRJTy4gUHVzaCB0aGUgbG9n aWMgdXAgdG8gdGhlIGNvbW1vbiBmdW5jdGlvbiB0byBhdm9pZA0KPj4+IGdldHRpbmcgYSBjb3B5 IGFuZCBwYXN0ZSB3cm9uZy4NCj4+Pg0KPj4+IFNpZ25lZC1vZmYtYnk6IEFsZXggQmVubsOpZSA8 YWxleC5iZW5uZWVAbGluYXJvLm9yZz4NCj4+PiBNZXNzYWdlLUlkOiA8MjAyMjA4MDIwOTUwMTAu MzMzMDc5My0xMS1hbGV4LmJlbm5lZUBsaW5hcm8ub3JnPg0KPj4+IFJldmlld2VkLWJ5OiBNaWNo YWVsIFMuIFRzaXJraW4gPG1zdEByZWRoYXQuY29tPg0KPj4+IFNpZ25lZC1vZmYtYnk6IE1pY2hh ZWwgUy4gVHNpcmtpbiA8bXN0QHJlZGhhdC5jb20+DQo+PiBUaGlzIHJlc3VsdHMgaW4gYSByZWdy ZXNzaW9uIGZvciBvdXIgczM5MHggQ0kgd2hlbiBkb2luZw0KPj4gc2F2ZS9yZXN0b3JlIG9mIGd1 ZXN0cyB3aXRoIHZzb2NrOg0KPj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAjMcKg IDB4MDAwMDAzZmY5YTI0ODU4MCByYWlzZSAobGliYy5zby42ICsgMHg0ODU4MCkNCj4+ICDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIzLCoCAweDAwMDAwM2ZmOWEyMmI1YzAgYWJvcnQg KGxpYmMuc28uNiArIDB4MmI1YzApDQo+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg ICMzwqAgMHgwMDAwMDNmZjlhMjQwOWRhIF9fYXNzZXJ0X2ZhaWxfYmFzZSAobGliYy5zby42ICsg MHg0MDlkYSkNCj4+ICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIzTCoCAweDAwMDAw M2ZmOWEyNDBhNGUgX19hc3NlcnRfZmFpbCAobGliYy5zby42ICsgMHg0MGE0ZSkNCj4+ICDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIzXCoCAweDAwMDAwMmFhMmQ2OWEwNjYgdmhvc3Rf dnNvY2tfY29tbW9uX3ByZV9zYXZlIChxZW11LXN5c3RlbS1zMzkweCArIDB4MzlhMDY2KQ0KPj4g IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAjNsKgIDB4MDAwMDAyYWEyZDU1NTcwZSB2 bXN0YXRlX3NhdmVfc3RhdGVfdiAocWVtdS1zeXN0ZW0tczM5MHggKyAweDI1NTcwZSkNCj4+ICDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIzfCoCAweDAwMDAwMmFhMmQ1NTYyMTggdm1z dGF0ZV9zYXZlX3N0YXRlIChxZW11LXN5c3RlbS1zMzkweCArIDB4MjU2MjE4KQ0KPj4gIMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAjOMKgIDB4MDAwMDAyYWEyZDU3MGJhNA0KPj4gcWVt dV9zYXZldm1fc3RhdGVfY29tcGxldGVfcHJlY29weV9ub25faXRlcmFibGUgKHFlbXUtc3lzdGVt LXMzOTB4ICsNCj4+IDB4MjcwYmE0KQ0KPj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCAjOcKgIDB4MDAwMDAyYWEyZDU3MTBiNiBxZW11X3NhdmV2bV9zdGF0ZV9jb21wbGV0ZV9wcmVj b3B5IChxZW11LXN5c3RlbS1zMzkweCArIDB4MjcxMGI2KQ0KPj4gIMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCAjMTAgMHgwMDAwMDJhYTJkNTY0ZDBlIG1pZ3JhdGlvbl9jb21wbGV0aW9u IChxZW11LXN5c3RlbS1zMzkweCArIDB4MjY0ZDBlKQ0KPj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCAjMTEgMHgwMDAwMDJhYTJkOGRiMjVjIHFlbXVfdGhyZWFkX3N0YXJ0IChxZW11 LXN5c3RlbS1zMzkweCArIDB4NWRiMjVjKQ0KPj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCAjMTIgMHgwMDAwMDNmZjlhMjk2MjQ4IHN0YXJ0X3RocmVhZCAobGliYy5zby42ICsgMHg5 NjI0OCkNCj4+ICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIzEzIDB4MDAwMDAzZmY5 YTMxMTgzZSB0aHJlYWRfc3RhcnQgKGxpYmMuc28uNiArIDB4MTExODNlKQ0KPj4gDQo+DQo+DQo+ IFNvbWV0aGluZyBsaWtlDQo+IGRpZmYgLS1naXQgYS9ody92aXJ0aW8vdmhvc3QtdnNvY2suYyBi L2h3L3ZpcnRpby92aG9zdC12c29jay5jDQo+IGluZGV4IDdkYzNjNzM5MzEyMi4uYjRkMDU2YWU2 ZjAxIDEwMDY0NA0KPiAtLS0gYS9ody92aXJ0aW8vdmhvc3QtdnNvY2suYw0KPiArKysgYi9ody92 aXJ0aW8vdmhvc3QtdnNvY2suYw0KPiBAQCAtNzMsNiArNzMsMTAgQEAgc3RhdGljIHZvaWQgdmhv c3RfdnNvY2tfc2V0X3N0YXR1cyhWaXJ0SU9EZXZpY2UgKnZkZXYsIHVpbnQ4X3Qgc3RhdHVzKQ0K PiAgICAgIGJvb2wgc2hvdWxkX3N0YXJ0ID0gdmlydGlvX2RldmljZV9zdGFydGVkKHZkZXYsIHN0 YXR1cyk7DQo+ICAgICAgaW50IHJldDsNCj4gICsgICAgaWYgKCF2ZGV2LT52bV9ydW5uaW5nKSB7 DQo+ICsgICAgICAgIHNob3VsZF9zdGFydCA9IGZhbHNlOw0KPiArICAgIH0NCj4gKw0KPiAgICAg IGlmICh2aG9zdF9kZXZfaXNfc3RhcnRlZCgmdnZjLT52aG9zdF9kZXYpID09IHNob3VsZF9zdGFy dCkgew0KPiAgICAgICAgICByZXR1cm47DQo+ICAgICAgfQ0KPg0KPiBoZWxwcy4NCj4NCj4gVGhl IHByb2JsZW0gc2VlbXMgdG8gYmUgdGhhdCB2aXJ0aW9fZGV2aWNlX3N0YXJ0ZWQgZG9lcyBpZ25v cmUNCj4gdm1fcnVubmluZyB3aGVuIHVzZV9zdGFydCBpcyBzZXQuDQoNCldvdWxkbid0IGl0IG1h a2UgbW9yZSBzZW5zZSB0byByZS1vcmRlciB0aGUgY2hlY2sgdGhlcmUsIHNvbWV0aGluZyBsaWtl Og0KDQogIHN0YXRpYyBpbmxpbmUgYm9vbCB2aXJ0aW9fZGV2aWNlX3N0YXJ0ZWQoVmlydElPRGV2 aWNlICp2ZGV2LCB1aW50OF90IHN0YXR1cykNCiAgew0KICAgICAgaWYgKCF2ZGV2LT52bV9ydW5u aW5nKSB7DQogICAgICAgICAgcmV0dXJuIGZhbHNlOw0KICAgICAgfQ0KDQogICAgICBpZiAodmRl di0+dXNlX3N0YXJ0ZWQpIHsNCiAgICAgICAgICByZXR1cm4gdmRldi0+c3RhcnRlZDsNCiAgICAg IH0NCg0KICAgICAgcmV0dXJuIHN0YXR1cyAmIFZJUlRJT19DT05GSUdfU19EUklWRVJfT0s7DQog IH0NCg0KSXMgdGhlIHByb2JsZW0gdGhhdCB2ZGV2LT5zdGFydGVkIGdldHMgZmlsbGVkIGR1cmlu ZyB0aGUgbWlncmF0aW9uIGJ1dA0KYmVjYXVzZSB0aGUgVk0gaXNuJ3QgcnVubmluZyB5ZXQgd2Ug Y2FuIG5ldmVyIGFjdHVhbGx5IHJ1bj8NCg0KLS0gDQpBbGV4IEJlbm7DqWUNCg==