Re: [PATCH RFC v2 13/13] net/vhost-user: add memory isolation

[Markus Armbruster <armbru@redhat.com>]

Connor Kite <connorkite@gmail.com> writes:

> Add a memory-isolation property to NetdevPassOptions and
> NetDevVhostUserOptions in net.json.  This property will
> be used for vhost-user devices to disable access to guest
> memory from vhost-user backends.
>
> Signed-off-by: Connor Kite <connorkite@gmail.com>

[...]

> diff --git a/qapi/net.json b/qapi/net.json
> index 1a6382825c..add7cb5408 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -213,6 +213,9 @@
>  #
>  # @param: parameter to pass to passt command
>  #
> +# @memory-isolation: isolate guest memory from vhost-user back-end
> +#     (default: false) (Since 11.2)
> +#

Any guidance on when to enable it?

>  # Since: 10.1
>  ##
>  { 'struct': 'NetdevPasstOptions',
> @@ -250,7 +253,8 @@
>      '*ipv6':               'bool',
>      '*tcp-ports':          ['PasstPortForward'],
>      '*udp-ports':          ['PasstPortForward'],
> -    '*param':              ['PasstParameter'] },
> +    '*param':              ['PasstParameter'],
> +    '*memory-isolation':   'bool'},
>      'if': 'CONFIG_PASST' }
>  
>  ##
> @@ -685,13 +689,17 @@
>  # @queues: number of queues to be created for multiqueue vhost-user
>  #     (default: 1) (Since 2.5)
>  #
> +# @memory-isolation: isolate guest memory from vhost-user back-end
> +#     (default: false) (Since 11.2)

Likewise.

> +#
>  # Since: 2.1
>  ##
>  { 'struct': 'NetdevVhostUserOptions',
>    'data': {
> -    'chardev':        'str',
> -    '*vhostforce':    'bool',
> -    '*queues':        'int' } }
> +    'chardev':              'str',
> +    '*vhostforce':          'bool',
> +    '*queues':              'int',
> +    '*memory-isolation':    'bool' } }
>  
>  ##
>  # @NetdevVhostVDPAOptions: