* [PATCH 5.10] gpu/drm/virtio: fix error return in vgdev_output_init()
@ 2025-09-22 14:44 Alexandr Sapozhnkiov
2025-10-08 16:47 ` Dmitry Osipenko
2025-10-09 3:12 ` Dmitry Osipenko
0 siblings, 2 replies; 3+ messages in thread
From: Alexandr Sapozhnkiov @ 2025-09-22 14:44 UTC (permalink / raw)
To: David Airlie, Gerd Hoffmann, Gurchetan Singh, Chia-I Wu,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
Daniel Vetter, dri-devel, virtualization
Cc: Alexandr Sapozhnikov, lvc-project
From: Alexandr Sapozhnikov <alsp705@gmail.com>
Return value of function drm_crtc_init_with_planes(),
called at virtgpu_display.c:276, is not checked,
but it is usually checked for this function
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Alexandr Sapozhnikov <alsp705@gmail.com>
---
drivers/gpu/drm/virtio/virtgpu_display.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
index ad924a8502e9..59b652e8a630 100644
--- a/drivers/gpu/drm/virtio/virtgpu_display.c
+++ b/drivers/gpu/drm/virtio/virtgpu_display.c
@@ -253,6 +253,7 @@ static const struct drm_connector_funcs virtio_gpu_connector_funcs = {
static int vgdev_output_init(struct virtio_gpu_device *vgdev, int index)
{
+ int ret;
struct drm_device *dev = vgdev->ddev;
struct virtio_gpu_output *output = vgdev->outputs + index;
struct drm_connector *connector = &output->conn;
@@ -273,8 +274,10 @@ static int vgdev_output_init(struct virtio_gpu_device *vgdev, int index)
cursor = virtio_gpu_plane_init(vgdev, DRM_PLANE_TYPE_CURSOR, index);
if (IS_ERR(cursor))
return PTR_ERR(cursor);
- drm_crtc_init_with_planes(dev, crtc, primary, cursor,
+ ret = drm_crtc_init_with_planes(dev, crtc, primary, cursor,
&virtio_gpu_crtc_funcs, NULL);
+ if (ret)
+ return ret;
drm_crtc_helper_add(crtc, &virtio_gpu_crtc_helper_funcs);
drm_connector_init(dev, connector, &virtio_gpu_connector_funcs,
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 5.10] gpu/drm/virtio: fix error return in vgdev_output_init()
2025-09-22 14:44 [PATCH 5.10] gpu/drm/virtio: fix error return in vgdev_output_init() Alexandr Sapozhnkiov
@ 2025-10-08 16:47 ` Dmitry Osipenko
2025-10-09 3:12 ` Dmitry Osipenko
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Osipenko @ 2025-10-08 16:47 UTC (permalink / raw)
To: Alexandr Sapozhnkiov, David Airlie, Gerd Hoffmann,
Gurchetan Singh, Chia-I Wu, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Daniel Vetter, dri-devel, virtualization
Cc: lvc-project
On 9/22/25 17:44, Alexandr Sapozhnkiov wrote:
> From: Alexandr Sapozhnikov <alsp705@gmail.com>
>
> Return value of function drm_crtc_init_with_planes(),
> called at virtgpu_display.c:276, is not checked,
> but it is usually checked for this function
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> Signed-off-by: Alexandr Sapozhnikov <alsp705@gmail.com>
> ---
> drivers/gpu/drm/virtio/virtgpu_display.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
> index ad924a8502e9..59b652e8a630 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_display.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_display.c
> @@ -253,6 +253,7 @@ static const struct drm_connector_funcs virtio_gpu_connector_funcs = {
>
> static int vgdev_output_init(struct virtio_gpu_device *vgdev, int index)
> {
> + int ret;
> struct drm_device *dev = vgdev->ddev;
> struct virtio_gpu_output *output = vgdev->outputs + index;
> struct drm_connector *connector = &output->conn;
> @@ -273,8 +274,10 @@ static int vgdev_output_init(struct virtio_gpu_device *vgdev, int index)
> cursor = virtio_gpu_plane_init(vgdev, DRM_PLANE_TYPE_CURSOR, index);
> if (IS_ERR(cursor))
> return PTR_ERR(cursor);
> - drm_crtc_init_with_planes(dev, crtc, primary, cursor,
> + ret = drm_crtc_init_with_planes(dev, crtc, primary, cursor,
> &virtio_gpu_crtc_funcs, NULL);
> + if (ret)
> + return ret;
> drm_crtc_helper_add(crtc, &virtio_gpu_crtc_helper_funcs);
>
> drm_connector_init(dev, connector, &virtio_gpu_connector_funcs,
Patch will need a cosmetic correction for the indentation that I'll
change while applying, thanks.
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
--
Best regards,
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 5.10] gpu/drm/virtio: fix error return in vgdev_output_init()
2025-09-22 14:44 [PATCH 5.10] gpu/drm/virtio: fix error return in vgdev_output_init() Alexandr Sapozhnkiov
2025-10-08 16:47 ` Dmitry Osipenko
@ 2025-10-09 3:12 ` Dmitry Osipenko
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Osipenko @ 2025-10-09 3:12 UTC (permalink / raw)
To: Alexandr Sapozhnkiov, David Airlie, Gerd Hoffmann,
Gurchetan Singh, Chia-I Wu, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Daniel Vetter, dri-devel, virtualization
Cc: lvc-project
On 9/22/25 17:44, Alexandr Sapozhnkiov wrote:
> From: Alexandr Sapozhnikov <alsp705@gmail.com>
>
> Return value of function drm_crtc_init_with_planes(),
> called at virtgpu_display.c:276, is not checked,
> but it is usually checked for this function
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> Signed-off-by: Alexandr Sapozhnikov <alsp705@gmail.com>
> ---
> drivers/gpu/drm/virtio/virtgpu_display.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
> index ad924a8502e9..59b652e8a630 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_display.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_display.c
> @@ -253,6 +253,7 @@ static const struct drm_connector_funcs virtio_gpu_connector_funcs = {
Applied to misc-next with corrected coding style and edited commit
message, thanks.
--
Best regards,
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-09 3:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-22 14:44 [PATCH 5.10] gpu/drm/virtio: fix error return in vgdev_output_init() Alexandr Sapozhnkiov
2025-10-08 16:47 ` Dmitry Osipenko
2025-10-09 3:12 ` Dmitry Osipenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).