virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Si-Wei Liu <si-wei.liu@oracle.com>
To: Parav Pandit <parav@nvidia.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: "virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"sridhar.samudrala@intel.com" <sridhar.samudrala@intel.com>,
	"jesse.brandeburg@intel.com" <jesse.brandeburg@intel.com>,
	Gavi Teitz <gavi@nvidia.com>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>,
	"loseweigh@gmail.com" <loseweigh@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	Gavin Li <gavinl@nvidia.com>
Subject: Re: [virtio-dev] RE: [PATCH v5 2/2] virtio-net: use mtu size as buffer length for big packets
Date: Wed, 7 Sep 2022 15:57:33 -0700	[thread overview]
Message-ID: <010b795e-7f90-0ea6-e4d6-88a706c160a6@oracle.com> (raw)
In-Reply-To: <PH0PR12MB548125D85533125828CE8454DC419@PH0PR12MB5481.namprd12.prod.outlook.com>



On 9/7/2022 3:11 PM, Parav Pandit wrote:
>> From: Si-Wei Liu <si-wei.liu@oracle.com>
>> Sent: Wednesday, September 7, 2022 5:40 PM
>>
>>
>> On 9/7/2022 12:51 PM, Parav Pandit wrote:
>>>> And I'd like commit log to include results of perf testing
>>>> - with indirect feature on
>>> Which device do you suggest using for this test?
>>>
>> You may use software vhost-net backend with and without fix to compare.
>> Since this driver fix effectively lowers down the buffer size for the
>> indirect=on case as well,
> Do you have sample example for this?

ip link add link ens300f1 name macvtap1 address $mac type macvtap mode 
bridge
ifindex1=`cat /sys/class/net/macvtap1/ifindex`

qemu-system-x86_64 \
   ...
   -netdev type=tap,id=hnet1,vhost=on,fd=25,vhostfd=27 \
   -device 
virtio-net-pci,netdev=hnet1,id=vnet1,mac=$mac,host_mtu=9000,mrg_rxbuf=off,guest_tso4=off,guest_tso6=off,guest_ecn=off,guest_ufo=off,indirect_desc=on 
\
   25<>/dev/tap${ifindex1} 27<>/dev/vhost-net

indirect_desc=on is not actually required as it's on by default if not 
specified.

-Siwei
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2022-09-07 22:58 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220901021038.84751-1-gavinl@nvidia.com>
     [not found] ` <20220901021038.84751-3-gavinl@nvidia.com>
2022-09-07  2:17   ` [virtio-dev] [PATCH v5 2/2] virtio-net: use mtu size as buffer length for big packets Jason Wang
2022-09-07  5:31   ` Michael S. Tsirkin
     [not found]     ` <0355d1e4-a3cf-5b16-8c7f-b39b1ec14ade@nvidia.com>
2022-09-07  9:26       ` Michael S. Tsirkin
2022-09-07 14:08         ` Parav Pandit via Virtualization
2022-09-07 14:29           ` Michael S. Tsirkin
2022-09-07 14:33             ` Parav Pandit via Virtualization
2022-09-07 14:40               ` Michael S. Tsirkin
2022-09-07 16:12                 ` Parav Pandit via Virtualization
2022-09-07 18:15                   ` Michael S. Tsirkin
2022-09-07 19:06                     ` Parav Pandit via Virtualization
2022-09-07 19:11                       ` Michael S. Tsirkin
2022-09-07 19:18                         ` Parav Pandit via Virtualization
2022-09-07 19:23                           ` Michael S. Tsirkin
2022-09-07 19:27                             ` Parav Pandit via Virtualization
2022-09-07 19:36                               ` Michael S. Tsirkin
2022-09-07 19:37                                 ` Michael S. Tsirkin
2022-09-07 19:54                                   ` Parav Pandit via Virtualization
2022-09-07 19:51                                 ` Parav Pandit via Virtualization
2022-09-07 21:39                                   ` [virtio-dev] " Si-Wei Liu
2022-09-07 22:11                                     ` Parav Pandit via Virtualization
2022-09-07 22:57                                       ` Si-Wei Liu [this message]
2022-09-22  9:26                                   ` Michael S. Tsirkin
2022-09-22 10:07                                     ` Parav Pandit via Virtualization
2022-09-07 20:04                                 ` Parav Pandit via Virtualization
2022-09-22  9:35   ` Michael S. Tsirkin
2022-09-22 10:04     ` Parav Pandit via Virtualization
2022-09-22 10:14       ` Michael S. Tsirkin
2022-09-22 10:29         ` Parav Pandit via Virtualization
     [not found]         ` <20220922053458.66f31136@kernel.org>
2022-10-05 10:29           ` Parav Pandit via Virtualization

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=010b795e-7f90-0ea6-e4d6-88a706c160a6@oracle.com \
    --to=si-wei.liu@oracle.com \
    --cc=davem@davemloft.net \
    --cc=gavi@nvidia.com \
    --cc=gavinl@nvidia.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=loseweigh@gmail.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=parav@nvidia.com \
    --cc=sridhar.samudrala@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).