Re: [PATCH linux-next v3 2/6] vdpa: Introduce query of device config layout

[Jason Wang <jasowang@redhat.com>]

在 2021/6/22 下午10:03, Parav Pandit 写道:
>> Is it better to use a separate enum for net specific attributes?
>>
> Yes, because they are only net specific.
> I guess it is related to your below question.
>
>> Another question (sorry if it has been asked before). Can we simply
>> return the config (binary) to the userspace, then usespace can use the
>> existing uAPI like virtio_net_config plus the feature to explain the config?
>>
> We did discuss in v2.
> Usually returning the whole blob and parsing is not desired via netlink.
> Returning individual fields give the full flexibility to return only the valid fields.
> Otherwise we need to implement another bitmask too to tell which fields from the struct are valid and share with user space.
> Returning individual fields is the widely used approach.


The main concerns are:

1) The blob will be self contained if it was passed with the negotiated 
features, so we don't need bitmask.
2) Using individual fields means it must duplicate the config fields of 
every virtio devices

And actually, it's not the binary blob since uapi clearly define the 
format (e.g struct virtio_net_config), can we find a way to use that?  
E.g introduce device/net specific command and passing the blob with 
length and negotiated features.

Thanks


>

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization