From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: "Alexander Graf" <graf@amazon.com>,
"Jason Wang" <jasowang@redhat.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"open list:VIRTIO CORE" <virtualization@lists.linux.dev>,
"open list" <linux-kernel@vger.kernel.org>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v3] virtio_ring: Add READ_ONCE annotations for device-writable fields
Date: Tue, 3 Feb 2026 11:46:13 +0000 [thread overview]
Message-ID: <04ac8ca2-a54d-48e0-8dc2-e1640aedcb59@wdc.com> (raw)
In-Reply-To: <1770107244.8746088-1-xuanzhuo@linux.alibaba.com>
On 2/3/26 9:29 AM, Xuan Zhuo wrote:
>> +/*
>> + * Accessors for device-writable fields in virtio rings.
>> + * These fields are concurrently written by the device and read by the driver.
>> + * Use READ_ONCE() to prevent compiler optimizations, document the
>> + * intentional data race and prevent KCSAN warnings.
>> + */
>> +static inline u16 vring_read_split_used_idx(const struct vring_virtqueue *vq)
> "inline" is not recommended in *.c files.
>
> Ohters LGTM.
>
> Thanks.
Is it?
johannes@neo:~/src/linux (master)$ git grep -E "\bstatic inline\b"
{arch,drivers,fs,mm}/**.c | wc -l
18295
That's new to me, sorry. But if there's consensus I can re-send the
patch without inline.
next prev parent reply other threads:[~2026-02-03 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 10:28 [PATCH v3] virtio_ring: Add READ_ONCE annotations for device-writable fields Johannes Thumshirn
2026-02-03 8:27 ` Xuan Zhuo
2026-02-03 11:46 ` Johannes Thumshirn [this message]
2026-02-03 12:02 ` Michael S. Tsirkin
2026-02-03 17:05 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04ac8ca2-a54d-48e0-8dc2-e1640aedcb59@wdc.com \
--to=johannes.thumshirn@wdc.com \
--cc=eperezma@redhat.com \
--cc=graf@amazon.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox