From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH 1/3] vhost: fix skb leak in handle_rx() Date: Fri, 1 Dec 2017 15:11:05 +0800 Message-ID: <09e75683-4c49-7446-e13e-93b316ed270c@redhat.com> References: <1512107669-27572-1-git-send-email-wexu@redhat.com> <1512107669-27572-2-git-send-email-wexu@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1512107669-27572-2-git-send-email-wexu@redhat.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: wexu@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: mjrosato@linux.vnet.ibm.com, mst@redhat.com List-Id: virtualization@lists.linuxfoundation.org CgpPbiAyMDE35bm0MTLmnIgwMeaXpSAxMzo1NCwgd2V4dUByZWRoYXQuY29tIHdyb3RlOgo+IEZy b206IFdlaSBYdSA8d2V4dUByZWRoYXQuY29tPgo+Cj4gTWF0dGhldyBmb3VuZCBhIHJvdWdobHkg NDAlIHRjcCB0aHJvdWdocHV0IHJlZ3Jlc3Npb24gd2l0aCBjb21taXQKPiBjNjdkZjExZih2aG9z dF9uZXQ6IHRyeSBiYXRjaCBkZXF1aW5nIGZyb20gc2tiIGFycmF5KSBhcyBkaXNjdXNzZWQKPiBp biB0aGUgZm9sbG93aW5nIHRocmVhZDoKPiBodHRwczovL3d3dy5tYWlsLWFyY2hpdmUuY29tL25l dGRldkB2Z2VyLmtlcm5lbC5vcmcvbXNnMTg3OTM2Lmh0bWwKPgo+IEV2ZW50dWFsbHkgd2UgZmln dXJlZCBvdXQgdGhhdCBpdCB3YXMgYSBza2IgbGVhayBpbiBoYW5kbGVfcngoKQo+IHdoZW4gc2Vu ZGluZyBwYWNrZXRzIHRvIHRoZSBWTS4gVGhpcyB1c3VhbGx5IGhhcHBlbnMgd2hlbiBhIGd1ZXN0 Cj4gY2FuIG5vdCBkcmFpbiBvdXQgdnEgYXMgZmFzdCBhcyB2aG9zdCBmaWxscyBpbiwgYWZ0ZXJ3 YXJkcyBpdCBzZXRzCj4gb2ZmIHRoZSB0cmFmZmljIGphbSBhbmQgbGVha3Mgc2tiKHMpIHdoaWNo IG9jY3VycyBhcyBubyBoZWFkY291bnQKPiB0byBzZW5kIG9uIHRoZSB2cSBmcm9tIHZob3N0IHNp ZGUuCj4KPiBUaGlzIGNhbiBiZSBhdm9pZGVkIGJ5IG1ha2luZyBzdXJlIHdlIGhhdmUgZ290IGVu b3VnaCBoZWFkY291bnQKPiBiZWZvcmUgYWN0dWFsbHkgY29uc3VtaW5nIGEgc2tiIGZyb20gdGhl IGJhdGNoZWQgcnggYXJyYXkgd2hpbGUKPiB0cmFuc21pdHRpbmcsIHdoaWNoIGlzIHNpbXBseSBk b25lIGJ5IG1vdmluZyBjaGVja2luZyB0aGUgemVybwo+IGhlYWRjb3VudCBhIGJpdCBhaGVhZC4K Pgo+IFNpZ25lZC1vZmYtYnk6IFdlaSBYdSA8d2V4dUByZWRoYXQuY29tPgo+IFJlcG9ydGVkLWJ5 OiBNYXR0aGV3IFJvc2F0byA8bWpyb3NhdG9AbGludXgudm5ldC5pYm0uY29tPgo+IC0tLQo+ICAg ZHJpdmVycy92aG9zdC9uZXQuYyB8IDIwICsrKysrKysrKystLS0tLS0tLS0tCj4gICAxIGZpbGUg Y2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy92aG9zdC9uZXQuYyBiL2RyaXZlcnMvdmhvc3QvbmV0LmMKPiBpbmRleCA4ZDYy NmQ3Li5jN2JkZWI2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdmhvc3QvbmV0LmMKPiArKysgYi9k cml2ZXJzL3Zob3N0L25ldC5jCj4gQEAgLTc3OCwxNiArNzc4LDYgQEAgc3RhdGljIHZvaWQgaGFu ZGxlX3J4KHN0cnVjdCB2aG9zdF9uZXQgKm5ldCkKPiAgIAkJLyogT24gZXJyb3IsIHN0b3AgaGFu ZGxpbmcgdW50aWwgdGhlIG5leHQga2ljay4gKi8KPiAgIAkJaWYgKHVubGlrZWx5KGhlYWRjb3Vu dCA8IDApKQo+ICAgCQkJZ290byBvdXQ7Cj4gLQkJaWYgKG52cS0+cnhfYXJyYXkpCj4gLQkJCW1z Zy5tc2dfY29udHJvbCA9IHZob3N0X25ldF9idWZfY29uc3VtZSgmbnZxLT5yeHEpOwo+IC0JCS8q IE9uIG92ZXJydW4sIHRydW5jYXRlIGFuZCBkaXNjYXJkICovCj4gLQkJaWYgKHVubGlrZWx5KGhl YWRjb3VudCA+IFVJT19NQVhJT1YpKSB7Cj4gLQkJCWlvdl9pdGVyX2luaXQoJm1zZy5tc2dfaXRl ciwgUkVBRCwgdnEtPmlvdiwgMSwgMSk7Cj4gLQkJCWVyciA9IHNvY2stPm9wcy0+cmVjdm1zZyhz b2NrLCAmbXNnLAo+IC0JCQkJCQkgMSwgTVNHX0RPTlRXQUlUIHwgTVNHX1RSVU5DKTsKPiAtCQkJ cHJfZGVidWcoIkRpc2NhcmRlZCByeCBwYWNrZXQ6IGxlbiAlemRcbiIsIHNvY2tfbGVuKTsKPiAt CQkJY29udGludWU7Cj4gLQkJfQo+ICAgCQkvKiBPSywgbm93IHdlIG5lZWQgdG8ga25vdyBhYm91 dCBhZGRlZCBkZXNjcmlwdG9ycy4gKi8KPiAgIAkJaWYgKCFoZWFkY291bnQpIHsKPiAgIAkJCWlm ICh1bmxpa2VseSh2aG9zdF9lbmFibGVfbm90aWZ5KCZuZXQtPmRldiwgdnEpKSkgewo+IEBAIC04 MDAsNiArNzkwLDE2IEBAIHN0YXRpYyB2b2lkIGhhbmRsZV9yeChzdHJ1Y3Qgdmhvc3RfbmV0ICpu ZXQpCj4gICAJCQkgKiB0aGV5IHJlZmlsbGVkLiAqLwo+ICAgCQkJZ290byBvdXQ7Cj4gICAJCX0K PiArCQlpZiAobnZxLT5yeF9hcnJheSkKPiArCQkJbXNnLm1zZ19jb250cm9sID0gdmhvc3RfbmV0 X2J1Zl9jb25zdW1lKCZudnEtPnJ4cSk7Cj4gKwkJLyogT24gb3ZlcnJ1biwgdHJ1bmNhdGUgYW5k IGRpc2NhcmQgKi8KPiArCQlpZiAodW5saWtlbHkoaGVhZGNvdW50ID4gVUlPX01BWElPVikpIHsK PiArCQkJaW92X2l0ZXJfaW5pdCgmbXNnLm1zZ19pdGVyLCBSRUFELCB2cS0+aW92LCAxLCAxKTsK PiArCQkJZXJyID0gc29jay0+b3BzLT5yZWN2bXNnKHNvY2ssICZtc2csCj4gKwkJCQkJCSAxLCBN U0dfRE9OVFdBSVQgfCBNU0dfVFJVTkMpOwo+ICsJCQlwcl9kZWJ1ZygiRGlzY2FyZGVkIHJ4IHBh Y2tldDogbGVuICV6ZFxuIiwgc29ja19sZW4pOwo+ICsJCQljb250aW51ZTsKPiArCQl9Cj4gICAJ CS8qIFdlIGRvbid0IG5lZWQgdG8gYmUgbm90aWZpZWQgYWdhaW4uICovCj4gICAJCWlvdl9pdGVy X2luaXQoJm1zZy5tc2dfaXRlciwgUkVBRCwgdnEtPmlvdiwgaW4sIHZob3N0X2xlbik7Cj4gICAJ CWZpeHVwID0gbXNnLm1zZ19pdGVyOwoKSSBzdWdnZXN0IHRvIHJlb3JkZXIgdGhpcyBwYXRjaCB0 byAzLzMuCgpUaGFua3MKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxp bnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWls bWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u