From: Jason Wang <jasowang@redhat.com>
To: Eli Cohen <elic@nvidia.com>
Cc: lulu@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, eperezma@redhat.com,
stefanha@redhat.com, eli@mellanox.com, lingshan.zhu@intel.com,
rob.miller@broadcom.com
Subject: Re: [PATCH 10/21] vhost: support ASID in IOTLB API
Date: Wed, 30 Dec 2020 12:27:47 +0800 [thread overview]
Message-ID: <0fc761c7-6053-c098-a251-ae2f7380f95e@redhat.com> (raw)
In-Reply-To: <20201229102059.GB195479@mtl-vdi-166.wap.labs.mlnx>
On 2020/12/29 下午6:20, Eli Cohen wrote:
>> -static int vhost_process_iotlb_msg(struct vhost_dev *dev,
>> +static int vhost_process_iotlb_msg(struct vhost_dev *dev, u16 asid,
>> struct vhost_iotlb_msg *msg)
>> {
>> int ret = 0;
>>
>> + if (asid != 0)
>> + return -EINVAL;
>> +
>> mutex_lock(&dev->mutex);
>> vhost_dev_lock_vqs(dev);
>> switch (msg->type) {
>> @@ -1135,6 +1138,7 @@ ssize_t vhost_chr_write_iter(struct vhost_dev *dev,
>> struct vhost_iotlb_msg msg;
>> size_t offset;
>> int type, ret;
>> + u16 asid = 0;
> You assume asid occupies just 16 bits. So maybe you should reserve the
> other 16 bits for future extension:
>
> struct vhost_msg_v2 {
> __u32 type;
> - __u32 reserved;
> + __u16 asid;
> + __u16 reserved;
> union {
>
> Moreover, maybe this should be reflected in previous patches that use
> the asid:
>
> -static int mlx5_vdpa_set_map(struct vdpa_device *vdev, struct vhost_iotlb *iotlb)
> +static int mlx5_vdpa_set_map(struct vdpa_device *vdev, u16 asid,
> + struct vhost_iotlb *iotlb)
>
> -static int vhost_vdpa_process_iotlb_msg(struct vhost_dev *dev,
> +static int vhost_vdpa_process_iotlb_msg(struct vhost_dev *dev, u16 asid,
> struct vhost_iotlb_msg *msg)
>
> etc.
Good catch.
This is a bug of the code actually. Since I want to stick to 32bit to be
large enough for e.g PASID.
Will fix.
Thanks
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-12-30 4:28 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 6:47 [PATCH 00/21] Control VQ support in vDPA Jason Wang
2020-12-16 6:47 ` [PATCH 01/21] vhost: move the backend feature bits to vhost_types.h Jason Wang
2020-12-16 6:47 ` [PATCH 02/21] virtio-vdpa: don't set callback if virtio doesn't need it Jason Wang
2020-12-16 6:48 ` [PATCH 03/21] vhost-vdpa: passing iotlb to IOMMU mapping helpers Jason Wang
2020-12-16 6:48 ` [PATCH 04/21] vhost-vdpa: switch to use vhost-vdpa specific IOTLB Jason Wang
2020-12-16 6:48 ` [PATCH 05/21] vdpa: add the missing comment for nvqs in struct vdpa_device Jason Wang
2020-12-16 6:48 ` [PATCH 06/21] vdpa: introduce virtqueue groups Jason Wang
2021-01-04 10:04 ` Stefan Hajnoczi
2021-01-05 4:13 ` Jason Wang
2020-12-16 6:48 ` [PATCH 07/21] vdpa: multiple address spaces support Jason Wang
[not found] ` <20201229072832.GA195479@mtl-vdi-166.wap.labs.mlnx>
2020-12-30 4:00 ` Jason Wang
2020-12-30 4:04 ` Jason Wang
2020-12-16 6:48 ` [PATCH 08/21] vdpa: introduce config operations for associating ASID to a virtqueue group Jason Wang
2020-12-16 6:48 ` [PATCH 09/21] vhost_iotlb: split out IOTLB initialization Jason Wang
2020-12-16 6:48 ` [PATCH 10/21] vhost: support ASID in IOTLB API Jason Wang
[not found] ` <20201229102059.GB195479@mtl-vdi-166.wap.labs.mlnx>
2020-12-30 4:27 ` Jason Wang [this message]
2020-12-16 6:48 ` [PATCH 11/21] vhost-vdpa: introduce asid based IOTLB Jason Wang
[not found] ` <20201229114110.GC195479@mtl-vdi-166.wap.labs.mlnx>
2020-12-30 6:23 ` Jason Wang
[not found] ` <20201229120504.GE195479@mtl-vdi-166.wap.labs.mlnx>
2020-12-30 6:33 ` Jason Wang
[not found] ` <20201229115340.GD195479@mtl-vdi-166.wap.labs.mlnx>
2020-12-30 6:34 ` Jason Wang
2020-12-16 6:48 ` [PATCH 12/21] vhost-vdpa: introduce uAPI to get the number of virtqueue groups Jason Wang
[not found] ` <20201229122455.GF195479@mtl-vdi-166.wap.labs.mlnx>
2020-12-30 6:49 ` Jason Wang
[not found] ` <20201230100506.GB5241@mtl-vdi-166.wap.labs.mlnx>
2020-12-31 2:36 ` Jason Wang
2020-12-16 6:48 ` [PATCH 13/21] vhost-vdpa: introduce uAPI to get the number of address spaces Jason Wang
2020-12-16 6:48 ` [PATCH 14/21] vhost-vdpa: uAPI to get virtqueue group id Jason Wang
2020-12-16 6:48 ` [PATCH 15/21] vhost-vdpa: introduce uAPI to set group ASID Jason Wang
2020-12-16 6:48 ` [PATCH 16/21] vhost-vdpa: support ASID based IOTLB API Jason Wang
2020-12-16 6:48 ` [PATCH 17/21] vdpa_sim: split vdpasim_virtqueue's iov field in out_iov and in_iov Jason Wang
2020-12-16 6:48 ` [PATCH 18/21] vdpa_sim: advertise VIRTIO_NET_F_MTU Jason Wang
2020-12-16 6:48 ` [PATCH 19/21] vdpa_sim: factor out buffer completion logic Jason Wang
2020-12-16 6:48 ` [PATCH 20/21] vdpa_sim: filter destination mac address Jason Wang
2020-12-16 6:48 ` [PATCH 21/21] vdpasim: control virtqueue support Jason Wang
2020-12-17 20:19 ` kernel test robot
[not found] ` <20210111122601.GA172492@mtl-vdi-166.wap.labs.mlnx>
2021-01-12 3:11 ` Jason Wang
[not found] ` <CAJaqyWcRirQgz+n63rU2nYVH2RKqjQfwHGFLzOG=H46qRWuTog@mail.gmail.com>
2021-01-25 3:16 ` Jason Wang
2020-12-16 9:47 ` [PATCH 00/21] Control VQ support in vDPA Michael S. Tsirkin
2020-12-17 3:30 ` Jason Wang
2020-12-17 7:58 ` Michael S. Tsirkin
2020-12-17 9:02 ` Jason Wang
2020-12-17 22:28 ` Michael S. Tsirkin
2020-12-18 2:56 ` Jason Wang
[not found] ` <20220224212314.1326-1-gdawar@xilinx.com>
[not found] ` <20220224212314.1326-6-gdawar@xilinx.com>
2022-02-28 8:07 ` [RFC PATCH v2 05/19] vdpa: introduce virtqueue groups Jason Wang
2022-02-28 8:17 ` [RFC PATCH v2 00/19] Control VQ support in vDPA Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fc761c7-6053-c098-a251-ae2f7380f95e@redhat.com \
--to=jasowang@redhat.com \
--cc=eli@mellanox.com \
--cc=elic@nvidia.com \
--cc=eperezma@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rob.miller@broadcom.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).