From: Paolo Bonzini <pbonzini@redhat.com>
To: "Liu, Changpeng" <changpeng.liu@intel.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: "cavery@redhat.com" <cavery@redhat.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v4] virtio_blk: add DISCARD and WRIET ZEROES commands support
Date: Mon, 4 Jun 2018 12:02:48 +0200 [thread overview]
Message-ID: <102ec75b-68c9-a488-d0c3-223ab09254bc@redhat.com> (raw)
In-Reply-To: <FF7FC980937D6342B9D289F5F3C7C2625B6DD85E@SHSMSX103.ccr.corp.intel.com>
On 04/06/2018 06:14, Liu, Changpeng wrote:
>>> But I believe the specification says VIRTIO_BLK_T_OUT means direction, so
>>> OR the two bits together should compliance with the specification.
>> I cannot find that in the specification:
>>
>> http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html#x1-
>> 2020002
>>
>> and it would contradict the "The type of the request is either ... or
>> ..." wording that I quoted from the spec above.
>>
>> If you do find something in the spec, please let me know and we can
>> figure out how to make the spec consistent.
>
> I saw comments from file linux/usr/include/uapi/linux/virtio_blk.h, which says
> VIRTIO_BLK_T_OUT may be combined with other commands and means direction,
> the specification does not have such description.
I don't think it is in the specification indeed (however, 11 and 13 were
chosen so that VIRTIO_BLK_T_OUT can still indicate direction).
Paolo
next prev parent reply other threads:[~2018-06-04 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 1:42 [PATCH v4] virtio_blk: add DISCARD and WRIET ZEROES commands support Changpeng Liu
2018-05-31 10:30 ` Stefan Hajnoczi
2018-05-31 23:53 ` Liu, Changpeng
2018-06-01 8:59 ` Stefan Hajnoczi
2018-06-04 4:14 ` Liu, Changpeng
2018-06-04 10:02 ` Paolo Bonzini [this message]
2018-06-05 0:55 ` Liu, Changpeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=102ec75b-68c9-a488-d0c3-223ab09254bc@redhat.com \
--to=pbonzini@redhat.com \
--cc=cavery@redhat.com \
--cc=changpeng.liu@intel.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).