From: David Howells <dhowells@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, dhowells@redhat.com,
Dave Jones <davej@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Stephen Hemminger <shemminger@vyatta.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] virtio_pci: fix macro exported in uapi
Date: Mon, 20 May 2013 10:06:56 +0100 [thread overview]
Message-ID: <1032.1369040816@warthog.procyon.org.uk> (raw)
In-Reply-To: <87r4h2zf5y.fsf@rustcorp.com.au>
Rusty Russell <rusty@rustcorp.com.au> wrote:
> The point of the patch is that it's unusable:
>
> #define VIRTIO_PCI_CONFIG(dev) ((dev)->msix_enabled ? 24 : 20)
>
> ie. it's accessing a member of the kernel's virtio_pci_dev structure.
Ah, okay. In that case, zap it and see if anyone complains.
David
prev parent reply other threads:[~2013-05-20 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 16:44 [PATCH] virtio_pci: fix macro exported in uapi Michael S. Tsirkin
2013-05-17 0:09 ` Rusty Russell
2013-05-17 8:57 ` David Howells
2013-05-20 0:08 ` Rusty Russell
2013-05-20 9:06 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1032.1369040816@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=davej@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=shemminger@vyatta.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).