From: Rusty Russell <rusty@rustcorp.com.au>
To: Andi Kleen <ak@muc.de>
Cc: Andrew Morton <akpm@osdl.org>, Chris Wright <chrisw@sous-sol.org>,
virtualization <virtualization@lists.osdl.org>
Subject: Re: [PATCH 1/2] paravirt.h header
Date: Wed, 23 Aug 2006 11:20:07 +1000 [thread overview]
Message-ID: <1156296008.12015.8.camel@localhost.localdomain> (raw)
In-Reply-To: <20060822110635.d9072621.ak@muc.de>
On Tue, 2006-08-22 at 11:06 +0200, Andi Kleen wrote:
> On Tue, 22 Aug 2006 15:55:15 +1000
> Rusty Russell <rusty@rustcorp.com.au> wrote:
>
> > OK, this is the revised paravirt.h (Andi has seen this before), then the
> > second is the binary patching stuff. More things get added to the
> > paravirt struct in future patches, but this basic stuff hasn't changed
> > for some time.
>
> Thanks. I plan to revisit this after the .19 merge is done.
> Currently there is too much noise in the tree and even your
> tree seems to be still changing too quickly.
>
> The patch looks reasonable, except that you still have far too many
> of these nasty __s around asm and volatile.
Yes, the correct one I sent out later only has __ in two hunks (old code
which I moved): I will go through later and remove them all as a
separate patch if this annoys you. AFAICT, everything under #ifdef
__KERNEL__ can be de-underscored without any ill effects.
Thanks,
Rusty.
--
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law
prev parent reply other threads:[~2006-08-23 1:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-22 5:55 [PATCH 1/2] paravirt.h header Rusty Russell
2006-08-22 6:12 ` [PATCH 2/2] paravirt inline patching Rusty Russell
2006-08-22 9:14 ` Andi Kleen
2006-08-22 6:43 ` [PATCH 1/2] paravirt.h header Rusty Russell
2006-08-22 9:06 ` Andi Kleen
2006-08-23 1:20 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156296008.12015.8.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=chrisw@sous-sol.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).