From: Ian Campbell <Ian.Campbell@XenSource.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andrew Morton <akpm@osdl.org>,
Virtualization <virtualization@lists.osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH] Translate asm version of ELFNOTE macro into preprocessor macro
Date: Wed, 23 Aug 2006 16:14:34 +0100 [thread overview]
Message-ID: <1156346074.12949.129.camel@localhost.localdomain> (raw)
In-Reply-To: <44EC6B12.4060909@goop.org>
On Wed, 2006-08-23 at 07:49 -0700, Jeremy Fitzhardinge wrote:
> Ian Campbell wrote:
> > The first is that older gas does not support :varargs in .macro
> > definitions (in my testing 2.17 does while 2.15 does not, I don't know
> > when it became supported). The Changes file says binutils >= 2.12 so I
> > think we need to avoid using it. There are no other uses in mainline or
> > -mm. Old gas appears to just ignore it so you get "too many arguments"
> > type errors.
> >
> OK, seems reasonable. Eric Biederman solved this by having NOTE/ENDNOTE
> (or something like that) in his "bzImage with ELF header" patch, but I
> don't remember it being used in any way which is incompatible with using
> a CPP macro.
I can't find that patch, does NOTE/ENDNOTE just do the push/pop .note
section?
That would solve the problem with the first argument of the macro being
a string but the final argument could still be for .asciz note contents.
Ian.
next prev parent reply other threads:[~2006-08-23 15:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-23 11:49 [PATCH] Translate asm version of ELFNOTE macro into preprocessor macro Ian Campbell
2006-08-23 14:49 ` Jeremy Fitzhardinge
2006-08-23 15:14 ` Ian Campbell [this message]
2006-08-23 15:23 ` Jeremy Fitzhardinge
2006-08-23 17:11 ` Eric W. Biederman
2006-08-23 17:47 ` Jeremy Fitzhardinge
2006-08-23 19:43 ` Ian Campbell
2006-08-23 21:02 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156346074.12949.129.camel@localhost.localdomain \
--to=ian.campbell@xensource.com \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).