From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, virtualization@lists.osdl.org,
akpm@osdl.org, nickpiggin@yahoo.com.au, frankeh@watson.ibm.com,
rhim@cc.gateh.edu
Subject: Re: [patch 4/9] Guest page hinting: volatile swap cache.
Date: Fri, 01 Sep 2006 17:33:22 +0200 [thread overview]
Message-ID: <1157124802.21733.16.camel@localhost> (raw)
In-Reply-To: <1157122713.28577.71.camel@localhost.localdomain>
On Fri, 2006-09-01 at 07:58 -0700, Dave Hansen wrote:
> > +#if defined(CONFIG_PAGE_STATES)
>
> This is a bit odd. Why not use an #ifdef like the rest of the kernel?
Personal preference I guess. If you have multiple macros you want to
test for you need to use "#if defined(a) && defined(b)", there is no
equivalent #ifndef notation.
--
blue skies,
Martin.
Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2006-09-01 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-01 11:10 [patch 4/9] Guest page hinting: volatile swap cache Martin Schwidefsky
2006-09-01 14:58 ` Dave Hansen
2006-09-01 15:33 ` Martin Schwidefsky [this message]
2006-09-01 15:04 ` Dave Hansen
2006-09-01 15:37 ` Martin Schwidefsky
2006-09-01 15:52 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157124802.21733.16.camel@localhost \
--to=schwidefsky@de.ibm.com \
--cc=akpm@osdl.org \
--cc=frankeh@watson.ibm.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=rhim@cc.gateh.edu \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).