From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Schwidefsky Subject: Re: [patch 3/9] Guest page hinting: volatile page cache. Date: Fri, 01 Sep 2006 19:42:00 +0200 Message-ID: <1157132520.21733.78.camel@localhost> References: <20060901110948.GD15684@skybase> <1157122667.28577.69.camel@localhost.localdomain> <1157124674.21733.13.camel@localhost> <44F8563B.3050505@shadowen.org> <1157126640.21733.43.camel@localhost> <1157127483.28577.117.camel@localhost.localdomain> <1157127943.21733.52.camel@localhost> <1157128634.28577.139.camel@localhost.localdomain> <1157129762.21733.63.camel@localhost> <1157130970.28577.150.camel@localhost.localdomain> Reply-To: schwidefsky@de.ibm.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1157130970.28577.150.camel@localhost.localdomain> Sender: linux-kernel-owner@vger.kernel.org To: Dave Hansen Cc: Andy Whitcroft , linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, akpm@osdl.org, nickpiggin@yahoo.com.au, frankeh@watson.ibm.com List-Id: virtualization@lists.linuxfoundation.org On Fri, 2006-09-01 at 10:16 -0700, Dave Hansen wrote: > This feels like something that can be done with RCU. The > __page_discard() is the write operation, right? So, take an rcu write > lock inside of the page discard function, and read locks over the > current places where PG_discarded is set. > > That should make sure that the discard operation itself can't be done > concurrently with one of the __remove_from*() operations. Once the > write lock has been acquired, you just check page->mapping to see if the > a __remove_from*() operation has occurred while you waited. The problem of page discard vs. normal page remove is that the page can be remove and discarded at the same time. Both sides are writers in the sense that they want to remove the page from page cache. RCU doesn't not help with that kind of race. -- blue skies, Martin. Martin Schwidefsky Linux for zSeries Development & Services IBM Deutschland Entwicklung GmbH "Reality continues to ruin my life." - Calvin.