Linux virtualization list
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Glauber de Oliveira Costa <glommer@gmail.com>
Cc: virtualization@lists.osdl.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Unified lguest launcher
Date: Fri, 06 Apr 2007 12:19:43 +1000	[thread overview]
Message-ID: <1175825983.12230.666.camel@localhost.localdomain> (raw)
In-Reply-To: <5d6222a80704050743l3c387287kdbe7eb069b793d6e@mail.gmail.com>

On Thu, 2007-04-05 at 11:43 -0300, Glauber de Oliveira Costa wrote:
> and here's the new patch, merging rusty's suggestions and some more on my own.
> 
> May I upload this, or does Rusty (or any other) has some more suggestions?

This looks excellent!

There are a couple of extra spaces floating around, but that's trivial.
You use "errno = ESRCH; err()" where you could use "errx()".

Please merge it straight in. No need for a separate patch in the tree
for this I think, unless you plan more work?

Thanks!
Rusty.

      reply	other threads:[~2007-04-06  2:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-04 16:03 [PATCH] Unified lguest launcher Glauber de Oliveira Costa
2007-04-05  2:44 ` Rusty Russell
2007-04-05 14:43   ` Glauber de Oliveira Costa
2007-04-06  2:19     ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1175825983.12230.666.camel@localhost.localdomain \
    --to=rusty@rustcorp.com.au \
    --cc=glommer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox