From: Rusty Russell <rusty@rustcorp.com.au>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, virtualization@lists.osdl.org,
ak@suse.de, jeremy@goop.org
Subject: Re: [patch 2/9] lguest: the guest code
Date: Wed, 09 May 2007 21:59:17 +1000 [thread overview]
Message-ID: <1178711957.7286.87.camel@localhost.localdomain> (raw)
In-Reply-To: <84144f020705090316o5e3b6d89r74638ec8e4d396d4@mail.gmail.com>
On Wed, 2007-05-09 at 13:16 +0300, Pekka Enberg wrote:
> Hi Rusty,
>
> On 5/9/07, akpm@linux-foundation.org <akpm@linux-foundation.org> wrote:
> > +static void add_lguest_device(unsigned int index)
> > +{
> > + struct lguest_device *new;
> > +
> > + lguest_devices[index].status |= LGUEST_DEVICE_S_ACKNOWLEDGE;
> > + new = kmalloc(sizeof(struct lguest_device), GFP_KERNEL);
> > + if (!new) {
> > + printk(KERN_EMERG "Cannot allocate lguest device %u\n", index);
> > + lguest_devices[index].status |= LGUEST_DEVICE_S_FAILED;
>
> [snip]
>
> Any reason why we don't return an error here?
Hi Pekka,
Hmm, where would the error go?
A little confused,
Rusty.
next prev parent reply other threads:[~2007-05-09 11:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-09 9:51 [patch 2/9] lguest: the guest code akpm
2007-05-09 10:16 ` Pekka Enberg
2007-05-09 11:59 ` Rusty Russell [this message]
2007-05-09 12:13 ` Pekka Enberg
2007-05-09 12:32 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178711957.7286.87.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).