From: Rusty Russell <rusty@rustcorp.com.au>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, virtualization@lists.osdl.org,
ak@suse.de, jeremy@goop.org
Subject: Re: [patch 2/9] lguest: the guest code
Date: Wed, 09 May 2007 22:32:53 +1000 [thread overview]
Message-ID: <1178713973.7286.102.camel@localhost.localdomain> (raw)
In-Reply-To: <84144f020705090513q28784b69sd91cd2490514d44c@mail.gmail.com>
On Wed, 2007-05-09 at 15:13 +0300, Pekka Enberg wrote:
> Hi Rusty,
>
> On 5/9/07, Rusty Russell <rusty@rustcorp.com.au> wrote:
> > Hmm, where would the error go?
>
> Let it propagate: scan_devices -> lguest_bus_init -> do_initcalls. We
> probably don't want to panic() if bus_register and device_register
> fail there either.
Hi Pekka,
Hey, thanks, I didn't realize that do_initcalls() now takes some note
when an initcall fails. But I'm pretty sure a local error message is
more informative than "initcall at 0xc0123408: returned with error code
2" etc.
And I agree about the panic: bus_register and device_register should
panic for us if they fail this early in boot. But I don't think they
do...
Thanks,
Rusty.
prev parent reply other threads:[~2007-05-09 12:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-09 9:51 [patch 2/9] lguest: the guest code akpm
2007-05-09 10:16 ` Pekka Enberg
2007-05-09 11:59 ` Rusty Russell
2007-05-09 12:13 ` Pekka Enberg
2007-05-09 12:32 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178713973.7286.102.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).