From: Rusty Russell <rusty@rustcorp.com.au>
To: Tony Breeds <tony@bakeyournoodle.com>
Cc: john stultz <johnstul@us.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Matt Mackall <mpm@selenic.com>,
virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH 2/2] lguest: handle dodgy/non-existent TSC. Guest code.
Date: Wed, 04 Jul 2007 18:10:05 +1000 [thread overview]
Message-ID: <1183536605.6005.19.camel@localhost.localdomain> (raw)
In-Reply-To: <20070704064402.GB10345@bakeyournoodle.com>
On Wed, 2007-07-04 at 16:44 +1000, Tony Breeds wrote:
> Why bother installing an lguest_clock which is the same as jiffies?
> Wouldn't it be better to just use the system provided jiffies
> clocksource in the case where you haven't been provided with
> lguest_data.tsc_khz ?
Hi Tony!
Yes, but jiffies is the lowest-rated clock (so PIT will get chosen). I
initially mugged clocksource_jiffies.rating, but that felt wrong: it's
currently not registered when this code runs so it's a simple
assignment, but if code order was to change it would have to be a call
to clocksource_change_rating().
There's an internal clocksource_override which I could use, but I'd have
to make it non-static.
Maybe John has thoughts?
Thanks,
Rusty.
next prev parent reply other threads:[~2007-07-04 8:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 6:19 [PATCH 1/2] lguest: handle dodgy/non-existent TSC. Host code Rusty Russell
2007-07-04 6:20 ` [PATCH 2/2] lguest: handle dodgy/non-existent TSC. Guest code Rusty Russell
2007-07-04 6:44 ` Tony Breeds
2007-07-04 8:10 ` Rusty Russell [this message]
2007-07-05 15:37 ` john stultz
2007-07-05 17:56 ` Jeremy Fitzhardinge
2007-07-04 13:20 ` [PATCH 1/2] lguest: handle dodgy/non-existent TSC. Host code Matt Mackall
2007-07-05 1:38 ` Rusty Russell
2007-07-05 6:41 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1183536605.6005.19.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=johnstul@us.ibm.com \
--cc=mpm@selenic.com \
--cc=tony@bakeyournoodle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).