From: Rusty Russell <rusty@rustcorp.com.au>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Carsten Otte <cotte@de.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 3/3] Virtio draft IV: the net driver
Date: Wed, 11 Jul 2007 21:26:41 +1000 [thread overview]
Message-ID: <1184153201.6005.618.camel@localhost.localdomain> (raw)
In-Reply-To: <200707111228.30707.borntraeger@de.ibm.com>
On Wed, 2007-07-11 at 12:28 +0200, Christian Borntraeger wrote:
> Am Mittwoch, 4. Juli 2007 schrieb Rusty Russell:
> > +static void try_fill_recv(struct virtnet_info *vi)
> Hmm, so it allocates skbs until oom or until add_buf fails, right?
Yep.
> Do you expect the add_buf call to fail if we have enough buffers? Who defines
> the amount of buffers we can add via add_buf?
There will be some internal limit on how many buffers the virtio
implementation supports, but depends on that implementation. It could
be a number of buffers or a total number of descriptors.
Cheers,
Rusty.
next prev parent reply other threads:[~2007-07-11 11:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 4:12 [PATCH 1/3] Virtio draft IV Rusty Russell
2007-07-04 4:19 ` [PATCH 2/3] Virtio draft IV: the block driver Rusty Russell
2007-07-04 4:40 ` [PATCH 3/3] Virtio draft IV: the net driver Rusty Russell
2007-07-11 10:28 ` Christian Borntraeger
2007-07-11 11:26 ` Rusty Russell [this message]
2007-07-11 11:46 ` Christian Borntraeger
2007-07-12 2:23 ` Rusty Russell
2007-07-11 19:27 ` Caitlin Bestler
2007-07-11 10:45 ` Christian Borntraeger
2007-07-11 11:32 ` Rusty Russell
2007-07-11 20:44 ` David Miller
2007-07-12 2:21 ` Rusty Russell
2007-07-12 2:26 ` David Miller
2007-07-05 7:32 ` [PATCH 2/3] Virtio draft IV: the block driver Christian Borntraeger
2007-07-06 0:33 ` Rusty Russell
2007-07-23 11:13 ` Christian Borntraeger
2007-07-24 3:02 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184153201.6005.618.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).