From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH 3/3] Virtio draft IV: the net driver Date: Wed, 11 Jul 2007 21:26:41 +1000 Message-ID: <1184153201.6005.618.camel@localhost.localdomain> References: <1183522348.6110.37.camel@localhost.localdomain> <1183522765.6110.40.camel@localhost.localdomain> <1183524053.6110.45.camel@localhost.localdomain> <200707111228.30707.borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200707111228.30707.borntraeger@de.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Christian Borntraeger Cc: Carsten Otte , "David S. Miller" , Herbert Xu , virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On Wed, 2007-07-11 at 12:28 +0200, Christian Borntraeger wrote: > Am Mittwoch, 4. Juli 2007 schrieb Rusty Russell: > > +static void try_fill_recv(struct virtnet_info *vi) > Hmm, so it allocates skbs until oom or until add_buf fails, right? Yep. > Do you expect the add_buf call to fail if we have enough buffers? Who defines > the amount of buffers we can add via add_buf? There will be some internal limit on how many buffers the virtio implementation supports, but depends on that implementation. It could be a number of buffers or a total number of descriptors. Cheers, Rusty.