From: Rusty Russell <rusty@rustcorp.com.au>
To: Gabriel C <nix.or.die@googlemail.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
virtualization@lists.osdl.org
Subject: [PATCH] Make lguest compile with CONFIG_BLOCK=n and CONFIG_NET=n
Date: Mon, 30 Jul 2007 10:25:22 +1000 [thread overview]
Message-ID: <1185755123.12151.102.camel@localhost.localdomain> (raw)
In-Reply-To: <46ACAFBF.6060609@googlemail.com>
On Sun, 2007-07-29 at 17:18 +0200, Gabriel C wrote:
> Hi Rusty,
>
> Lguest should depend on BLOCK too , without BLOCK set I get this error:
Hi Gabriel,
Thanks for the report! It's probably better to fix this properly
rather than hack it as I did for NET.
Linus, please apply:
Gabriel C reports lguest doesn't compile with CONFIG_BLOCK=n. Fix
this by introducing a config var for the block device, which depends
on LGUEST && BLOCK. Do the same for the net driver, rather then
depending gratuitously on CONFIG_NET.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff -r 9e987fcabb16 drivers/block/Makefile
--- a/drivers/block/Makefile Mon Jul 30 09:47:25 2007 +1000
+++ b/drivers/block/Makefile Mon Jul 30 10:02:32 2007 +1000
@@ -31,4 +31,4 @@ obj-$(CONFIG_BLK_DEV_UB) += ub.o
obj-$(CONFIG_BLK_DEV_UB) += ub.o
obj-$(CONFIG_XEN_BLKDEV_FRONTEND) += xen-blkfront.o
-obj-$(CONFIG_LGUEST_GUEST) += lguest_blk.o
+obj-$(CONFIG_LGUEST_BLOCK) += lguest_blk.o
diff -r 9e987fcabb16 drivers/lguest/Kconfig
--- a/drivers/lguest/Kconfig Mon Jul 30 09:47:25 2007 +1000
+++ b/drivers/lguest/Kconfig Mon Jul 30 10:03:39 2007 +1000
@@ -1,6 +1,6 @@ config LGUEST
config LGUEST
tristate "Linux hypervisor example code"
- depends on X86 && PARAVIRT && NET && EXPERIMENTAL && !X86_PAE
+ depends on X86 && PARAVIRT && EXPERIMENTAL && !X86_PAE
select LGUEST_GUEST
select HVC_DRIVER
---help---
@@ -18,3 +18,11 @@ config LGUEST_GUEST
The guest needs code built-in, even if the host has lguest
support as a module. The drivers are tiny, so we build them
in too.
+
+config LGUEST_NET
+ tristate
+ depends on LGUEST_GUEST && NET
+
+config LGUEST_BLOCK
+ tristate
+ depends on LGUEST_GUEST && BLOCK
diff -r 9e987fcabb16 drivers/net/Makefile
--- a/drivers/net/Makefile Mon Jul 30 09:47:25 2007 +1000
+++ b/drivers/net/Makefile Mon Jul 30 10:02:22 2007 +1000
@@ -177,7 +177,7 @@ obj-$(CONFIG_HPLANCE) += hplance.o 7990.
obj-$(CONFIG_HPLANCE) += hplance.o 7990.o
obj-$(CONFIG_MVME147_NET) += mvme147.o 7990.o
obj-$(CONFIG_EQUALIZER) += eql.o
-obj-$(CONFIG_LGUEST_GUEST) += lguest_net.o
+obj-$(CONFIG_LGUEST_NET) += lguest_net.o
obj-$(CONFIG_MIPS_JAZZ_SONIC) += jazzsonic.o
obj-$(CONFIG_MIPS_AU1X00_ENET) += au1000_eth.o
obj-$(CONFIG_MIPS_SIM_NET) += mipsnet.o
next prev parent reply other threads:[~2007-07-30 0:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 15:18 [PATCH] BLOCK=n , LGUEST=m/y compile error Gabriel C
2007-07-30 0:25 ` Rusty Russell [this message]
2007-07-30 0:48 ` [PATCH] Make lguest compile with CONFIG_BLOCK=n and CONFIG_NET=n Satyam Sharma
2007-07-30 1:29 ` Gabriel C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185755123.12151.102.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=nix.or.die@googlemail.com \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).