From: Rusty Russell <rusty@rustcorp.com.au>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: lguest virtio_descriptor structure on 64bit
Date: Fri, 17 Aug 2007 21:13:07 +1000 [thread overview]
Message-ID: <1187349187.6449.119.camel@localhost.localdomain> (raw)
In-Reply-To: <200708171022.18799.borntraeger@de.ibm.com>
On Fri, 2007-08-17 at 10:22 +0200, Christian Borntraeger wrote:
> Hello Rusty,
>
> while playing with your virtio descriptor code, I realized that the desc_pages
> data structure is not 64 bit safe. struct lguest_desc desc[NUM_DESCS] can be
> smaller than a page, as struct lguest_desc is 24 bytes on 64bit systems. Lets
> add a char padding to make the next page really page aligned.
Indeed. This is something which would need fixing for a non-32 bit
platform.
> Btw. the new_io_desc.patch does not apply on current git. What base should I
> use?
Unfortunately, the lguest tree is undergoing a significant reshuffle as
files get moved (non-i386 support). The lguest patch queue as a whole
should apply tho.
Thanks!
Rusty.
prev parent reply other threads:[~2007-08-17 11:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 8:22 lguest virtio_descriptor structure on 64bit Christian Borntraeger
2007-08-17 11:13 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1187349187.6449.119.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=borntraeger@de.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox