From: Rusty Russell <rusty@rustcorp.com.au>
To: Arnd Bergmann <arnd@arndb.de>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
lguest <lguest@ozlabs.org>, Dor Laor <dor.laor@qumranet.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 1/6] virtio interace
Date: Sat, 22 Sep 2007 19:55:34 +1000 [thread overview]
Message-ID: <1190454934.27805.80.camel@localhost.localdomain> (raw)
In-Reply-To: <200709211622.22005.arnd@arndb.de>
On Fri, 2007-09-21 at 16:22 +0200, Arnd Bergmann wrote:
> On Friday 21 September 2007, Rusty Russell wrote:
> > Hmm, I guess we could have a PCI driver which claims all VIRTIO vendor
> > devices.
>
> yes, that was the idea.
>
> > Then it can call virtio_find_driver() (?) at the top of its
> > probe function to find if there's a matching virtio driver.
> > This PCI driver would have to be initialized after all the virtio
> > drivers are registered, but that's easy.
>
> No, just use the driver model, instead of working against it:
But now each virtio device has two "struct device"s, not one. And
you've made up a fictional bus to do it.
Yet for PCI systems, it really is a PCI device; exposing a second bus to
userspace just because we put a layer in our implementation is poor
form.
Perhaps this is the easiest way of doing it. But it's still wrong.
Rusty.
next prev parent reply other threads:[~2007-09-22 9:55 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1190289808.7262.223.camel@localhost.localdomain>
2007-09-20 12:09 ` [PATCH 1/6] virtio interace Rusty Russell
[not found] ` <1190290140.7262.228.camel@localhost.localdomain>
2007-09-20 12:12 ` [PATCH 2/6] virtio_config Rusty Russell
[not found] ` <1190290369.7262.231.camel@localhost.localdomain>
2007-09-20 12:14 ` [PATCH 3/6] virtio net driver Rusty Russell
2007-09-20 12:36 ` [kvm-devel] [PATCH 2/6] virtio_config Avi Kivity
[not found] ` <46F26958.4080102@qumranet.com>
2007-09-20 12:55 ` Avi Kivity
[not found] ` <46F26DC7.9040001@qumranet.com>
2007-09-21 1:50 ` Rusty Russell
[not found] ` <1190339435.19451.23.camel@localhost.localdomain>
2007-09-22 13:03 ` Avi Kivity
[not found] ` <1190290495.7262.235.camel@localhost.localdomain>
2007-09-20 12:16 ` [PATCH 4/6] virtio block driver Rusty Russell
[not found] ` <1190290606.7262.239.camel@localhost.localdomain>
2007-09-20 12:19 ` [PATCH 5/6] virtio console driver Rusty Russell
2007-09-20 12:27 ` [PATCH 4/6] virtio block driver Jens Axboe
[not found] ` <1190290761.7262.242.camel@localhost.localdomain>
2007-09-20 12:27 ` [PATCH 6/6] virtio ring helper Rusty Russell
[not found] ` <1190291234.7262.246.camel@localhost.localdomain>
2007-09-20 12:43 ` [kvm-devel] " Avi Kivity
[not found] ` <46F26AF6.60904@qumranet.com>
2007-09-21 2:04 ` Rusty Russell
[not found] ` <1190340251.19451.36.camel@localhost.localdomain>
2007-09-23 10:05 ` Avi Kivity
[not found] ` <46F63A64.9070200@qumranet.com>
2007-09-23 11:40 ` Rusty Russell
[not found] ` <1190547607.27805.120.camel@localhost.localdomain>
2007-09-23 11:46 ` Avi Kivity
2007-09-20 13:05 ` [PATCH 4/6] virtio block driver Jens Axboe
[not found] ` <20070920130519.GL2367@kernel.dk>
2007-09-21 2:06 ` Rusty Russell
2007-09-21 11:47 ` Jens Axboe
[not found] ` <20070921114703.GN2367@kernel.dk>
2007-09-21 12:30 ` Rusty Russell
[not found] ` <20070920122713.GK2367@kernel.dk>
2007-09-21 12:00 ` Rusty Russell
[not found] ` <1190376007.27805.19.camel@localhost.localdomain>
2007-09-21 12:27 ` Jens Axboe
[not found] ` <20070921122746.GO2367@kernel.dk>
2007-09-23 6:47 ` Rusty Russell
2007-09-21 10:48 ` [kvm-devel] [PATCH 3/6] virtio net driver Christian Borntraeger
[not found] ` <200709211248.11783.borntraeger@de.ibm.com>
2007-09-21 11:53 ` Rusty Russell
[not found] ` <1190375615.27805.9.camel@localhost.localdomain>
2007-09-21 12:36 ` Christian Borntraeger
[not found] ` <200709211436.43964.borntraeger@de.ibm.com>
2007-09-21 14:08 ` Herbert Xu
[not found] ` <20070921140833.GA12242@gondor.apana.org.au>
2007-09-21 14:42 ` Christian Borntraeger
[not found] ` <200709211642.25208.borntraeger@de.ibm.com>
2007-09-23 7:13 ` Rusty Russell
2007-09-20 12:27 ` [kvm-devel] [PATCH 1/6] virtio interace Avi Kivity
[not found] ` <46F2674A.2050403@qumranet.com>
2007-09-21 11:37 ` Rusty Russell
2007-09-21 12:05 ` Arnd Bergmann
[not found] ` <200709211405.32116.arnd@arndb.de>
2007-09-21 12:45 ` Rusty Russell
[not found] ` <1190378736.27805.54.camel@localhost.localdomain>
2007-09-21 14:22 ` Arnd Bergmann
[not found] ` <200709211622.22005.arnd@arndb.de>
2007-09-22 9:55 ` Rusty Russell [this message]
2007-09-22 10:01 ` Arnd Bergmann
[not found] ` <200709221201.33865.arnd@arndb.de>
2007-09-23 8:33 ` Rusty Russell
[not found] ` <1190536431.27805.109.camel@localhost.localdomain>
2007-09-23 11:20 ` Dor Laor
2007-09-20 13:43 ` [PATCH 0/6] virtio with config abstraction and ring implementation Dor Laor
[not found] ` <46F2791A.8070601@qumranet.com>
2007-09-20 13:50 ` [Lguest] [PATCH 0/6] virtio with config abstraction and ringimplementation Dor Laor
2007-09-21 3:20 ` [PATCH 0/6] virtio with config abstraction and ring implementation Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190454934.27805.80.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=arnd@arndb.de \
--cc=dor.laor@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=lguest@ozlabs.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).