From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Subject: Re: [PATCH v2 00/10] virtio-mem: paravirtualized memory Date: Mon, 30 Mar 2020 10:42:47 +0200 Message-ID: <11c87dee-e94e-0475-76d2-143adfd50d9d@redhat.com> References: <20200311171422.10484-1-david@redhat.com> <6858c4d8-7570-2c2b-5d53-1a7f994c14ee@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: kvm-owner@vger.kernel.org To: Pankaj Gupta Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Michal Hocko , Andrew Morton , "Michael S . Tsirkin" , Sebastien Boeuf , Samuel Ortiz , Robert Bradford , Luiz Capitulino , teawater , Igor Mammedov , "Dr . David Alan Gilbert" , Alexander Duyck , Alexander Potapenko , Anshuman Khandual , Anthony Yznaga List-Id: virtualization@lists.linuxfoundation.org On 29.03.20 17:41, Pankaj Gupta wrote: >>> Hi David, >>> >>> Trying to test the series with the Qemu branch(virtio-mem) mentioned. >>> Unfortunately, >>> not able to hotplug memory. Is anything changed from your previous posting >>> or I am doing something wrong? >>> >>> After giving value to "requested-size", I see size as zero. >>> >>> (qemu) qom-set vm0 requested-size 10G >>> (qemu) info memory-devices >>> Memory device [virtio-mem]: "vm0" >>> memaddr: 0x240000000 >>> node: 0 >>> requested-size: 10737418240 >>> size: 0 >>> max-size: 107374182400 >>> block-size: 2097152 >>> memdev: /objects/mem0 >>> >>> Guest kernel: 5.6.0-rc4 >>> Using same Qemu commandline arguments mentioned in cover-letter. >> >> Are you booting from an initrd? Are you compiling virtio-mem as a kernel >> module or into the kernel binary? > Ah was booting into wrong kernel version. Sorry! for the noise. > > Working perfectly for me. Tried various cmbinations for both > hotplug/unplug with multiple > NUMA nodes and verified result in guest. > > For the series, you can add: > Tested-by: Pankaj Gupta Awesome, thanks! -- Thanks, David / dhildenb