From: Juergen Gross <jgross@suse.com>
To: Michael Kelley <mikelley@microsoft.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"akataria@vmware.com" <akataria@vmware.com>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"apw@canonical.com" <apw@canonical.com>,
vkuznets <vkuznets@redhat.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"marcelo.cerri@canonical.com" <marcelo.cerri@canonical.com>,
KY Srinivasan <kys@microsoft.com>
Subject: Re: [PATCH 0/2] i8253: Fix PIT shutdown quirk on Hyper-V
Date: Fri, 2 Nov 2018 08:40:04 +0100 [thread overview]
Message-ID: <11f82d95-539c-b680-183b-b6c5c60468a8@suse.com> (raw)
In-Reply-To: <1541093374-10496-1-git-send-email-mikelley@microsoft.com>
On 01/11/2018 18:30, Michael Kelley wrote:
> pit_shutdown() doesn't work on Hyper-V because of a quirk in the
> PIT emulation. This problem exists in all versions of Hyper-V and
> had not been noticed previously. When the counter register is set
> to zero, the emulated PIT continues to interrupt @18.2 HZ.
>
> So add a test for running on Hyper-V, and use that test to skip
> setting the counter register when running on Hyper-V.
>
> This patch replaces a previously proposed patch with a different
> approach. This new approach follows comments from Thomas Gleixner.
Did you consider using a static_key instead? You could set it in
ms_hyperv_init_platform(). This would enable you to support future
Hyper-V versions which don't require avoiding to set the count to zero.
Juergen
next parent reply other threads:[~2018-11-02 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1541093374-10496-1-git-send-email-mikelley@microsoft.com>
2018-11-02 7:40 ` Juergen Gross [this message]
2018-11-03 17:22 ` [PATCH 0/2] i8253: Fix PIT shutdown quirk on Hyper-V Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11f82d95-539c-b680-183b-b6c5c60468a8@suse.com \
--to=jgross@suse.com \
--cc=akataria@vmware.com \
--cc=apw@canonical.com \
--cc=daniel.lezcano@linaro.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=mikelley@microsoft.com \
--cc=olaf@aepfle.de \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox