virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: mst@redhat.com
Cc: Amit Shah <amit.shah@redhat.com>,
	virtualization@linux-foundation.org, quintela@redhat.com
Subject: [PATCH 1/2] virtio: console: Fix type of 'len' as unsigned int
Date: Mon,  8 Mar 2010 14:16:59 +0530	[thread overview]
Message-ID: <1268038020-12539-2-git-send-email-amit.shah@redhat.com> (raw)
In-Reply-To: <1268038020-12539-1-git-send-email-amit.shah@redhat.com>

We declare 'len' as int type but it should be 'unsigned int', as
get_buf() wants it to be.

Signed-off-by: Amit Shah <amit.shah@redhat.com>
Reported-by: Juan Quintela <quintela@redhat.com>
---
 drivers/char/virtio_console.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 213373b..2bd6a9c 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -379,7 +379,7 @@ static ssize_t send_control_msg(struct port *port, unsigned int event,
 	struct scatterlist sg[1];
 	struct virtio_console_control cpkt;
 	struct virtqueue *vq;
-	int len;
+	unsigned int len;
 
 	if (!use_multiport(port->portdev))
 		return 0;
-- 
1.6.2.5

  reply	other threads:[~2010-03-08  8:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-08  8:46 [PATCH 0/2] virtio: console: Trivial fixes based on review comments Amit Shah
2010-03-08  8:46 ` Amit Shah [this message]
2010-03-08  8:47   ` [PATCH 2/2] virtio: console: Use better variable names for fill_queue operation Amit Shah
2010-03-08 10:34 ` [PATCH 0/2] virtio: console: Trivial fixes based on review comments Juan Quintela
2010-03-08 21:23 ` Michael S. Tsirkin
2010-03-09  3:55   ` Amit Shah
2010-03-09  6:28     ` Michael S. Tsirkin
2010-03-09  6:36       ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268038020-12539-2-git-send-email-amit.shah@redhat.com \
    --to=amit.shah@redhat.com \
    --cc=mst@redhat.com \
    --cc=quintela@redhat.com \
    --cc=virtualization@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).