From: Amit Shah <amit.shah@redhat.com>
To: virtualization@lists.linux-foundation.org
Cc: Amit Shah <amit.shah@redhat.com>, quintela@redhat.com, mst@redhat.com
Subject: [PATCH 5/6] virtio: console: Handle hot-plug/unplug config actions
Date: Fri, 19 Mar 2010 17:36:47 +0530 [thread overview]
Message-ID: <1269000408-29962-6-git-send-email-amit.shah@redhat.com> (raw)
In-Reply-To: <1269000408-29962-5-git-send-email-amit.shah@redhat.com>
The new way of handling hot-plug as well as unplug is via a
config interrupt.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
drivers/char/virtio_console.c | 53 +++++++++++++++++++++++++++++++++++++----
1 files changed, 48 insertions(+), 5 deletions(-)
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 9f2cbf0..06ca95c 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -1268,22 +1268,65 @@ static struct virtio_console_config *get_config(struct virtio_device *vdev,
}
/*
- * The workhandler for config-space updates.
+ * The workhandler for config-space updates. Only called when
+ * multiport is supported.
*
- * This is called when ports are hot-added.
+ * This is called when ports are hot-added and hot-removed.
*/
static void config_work_handler(struct work_struct *work)
{
- struct virtio_console_config virtconconf;
+ struct virtio_console_config *config;
struct ports_device *portdev;
struct virtio_device *vdev;
- int err;
+ unsigned int i, changed;
portdev = container_of(work, struct ports_device, config_work);
vdev = portdev->vdev;
- /* FIXME: Handle port hotplug/unplug */
+ config = get_config(vdev, true);
+ if (!config) {
+ dev_warn(&vdev->dev,
+ "Running out of memory on config change events\n");
+ return;
+ }
+
+ if (config->max_nr_ports != portdev->config->max_nr_ports) {
+ dev_warn(&vdev->dev,
+ "Host updated max_nr_ports, can't handle that now.\n");
+ goto free;
+ }
+
+ changed = 0;
+ for (i = 0; i < (config->max_nr_ports + 31) / 32; i++) {
+ u32 map;
+
+ map = config->ports_map[i] ^ portdev->config->ports_map[i];
+ while (map) {
+ struct port *port;
+ u32 port_nr;
+
+ changed++;
+ port_nr = find_next_bit_in_map(&map) + i * 32;
+ port = find_port_by_id(portdev, port_nr);
+ if (port)
+ remove_port(port);
+ else
+ add_port(portdev, port_nr);
+ }
+ portdev->config->ports_map[i] = config->ports_map[i];
+ }
+ if (!changed && find_port_by_id(portdev, 0)) {
+ /*
+ * No hot-plug / unplug activity. Port 0 might have
+ * been hot-added. Just send a 'ready' message in
+ * that case, since we already have it added.
+ */
+ send_control_msg(find_port_by_id(portdev, 0),
+ VIRTIO_CONSOLE_PORT_READY, 1);
+ }
+free:
+ kfree(config);
}
static int init_vqs(struct ports_device *portdev)
--
1.6.2.5
next prev parent reply other threads:[~2010-03-19 12:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 12:06 [PATCH 0/6] virtio: console: Fixes, abi update Amit Shah
2010-03-19 12:06 ` [PATCH 1/6] virtio: console: Generate a kobject CHANGE event on adding 'name' attribute Amit Shah
2010-03-19 12:06 ` [PATCH 2/6] virtio: console: Check if port is valid in resize_console Amit Shah
2010-03-19 12:06 ` [PATCH 3/6] virtio: console: Switch to using a port bitmap for port discovery Amit Shah
2010-03-19 12:06 ` [PATCH 4/6] virtio: console: Separate out get_config in a separate function Amit Shah
2010-03-19 12:06 ` Amit Shah [this message]
2010-03-19 12:06 ` [PATCH 6/6] virtio: console: Remove hot-unplug control message Amit Shah
2010-03-21 11:29 ` [PATCH 3/6] virtio: console: Switch to using a port bitmap for port discovery Michael S. Tsirkin
2010-03-22 4:04 ` Amit Shah
2010-03-22 8:53 ` Michael S. Tsirkin
2010-03-22 9:45 ` Amit Shah
2010-03-22 12:16 ` Michael S. Tsirkin
2010-03-22 12:31 ` Amit Shah
2010-03-21 11:44 ` [PATCH 0/6] virtio: console: Fixes, abi update Michael S. Tsirkin
2010-03-22 10:44 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269000408-29962-6-git-send-email-amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=mst@redhat.com \
--cc=quintela@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).