From: Amit Shah <amit.shah@redhat.com>
To: virtualization@lists.linux-foundation.org
Cc: Amit Shah <amit.shah@redhat.com>, mst@redhat.com
Subject: [PATCH 3/7] virtio: console: Add a __send_control_msg() that can send messages without a valid port
Date: Tue, 23 Mar 2010 14:27:56 +0530 [thread overview]
Message-ID: <1269334680-1369-4-git-send-email-amit.shah@redhat.com> (raw)
In-Reply-To: <1269334680-1369-3-git-send-email-amit.shah@redhat.com>
We will introduce control messages that operate on the device as a whole
rather than just ports. Make send_control_msg() a wrapper around
__send_control_msg() which does not need a valid port.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
drivers/char/virtio_console.c | 16 +++++++++++-----
1 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index c7894f3..99c36d4 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -372,22 +372,22 @@ out:
return ret;
}
-static ssize_t send_control_msg(struct port *port, unsigned int event,
- unsigned int value)
+static ssize_t __send_control_msg(struct ports_device *portdev, u32 port_id,
+ unsigned int event, unsigned int value)
{
struct scatterlist sg[1];
struct virtio_console_control cpkt;
struct virtqueue *vq;
unsigned int len;
- if (!use_multiport(port->portdev))
+ if (!use_multiport(portdev))
return 0;
- cpkt.id = port->id;
+ cpkt.id = port_id;
cpkt.event = event;
cpkt.value = value;
- vq = port->portdev->c_ovq;
+ vq = portdev->c_ovq;
sg_init_one(sg, &cpkt, sizeof(cpkt));
if (vq->vq_ops->add_buf(vq, sg, 1, 0, &cpkt) >= 0) {
@@ -398,6 +398,12 @@ static ssize_t send_control_msg(struct port *port, unsigned int event,
return 0;
}
+static ssize_t send_control_msg(struct port *port, unsigned int event,
+ unsigned int value)
+{
+ return __send_control_msg(port->portdev, port->id, event, value);
+}
+
static ssize_t send_buf(struct port *port, void *in_buf, size_t in_count)
{
struct scatterlist sg[1];
--
1.6.2.5
next prev parent reply other threads:[~2010-03-23 8:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 8:57 [PATCH 0/7] virtio: console: Fixes, new flexible way of discovering ports Amit Shah
2010-03-23 8:57 ` [PATCH 1/7] MAINTAINERS: Put the virtio-console entry in correct alphabetical order Amit Shah
2010-03-23 8:57 ` [PATCH 2/7] virtio: console: Remove config work handler Amit Shah
2010-03-23 8:57 ` Amit Shah [this message]
2010-03-23 8:57 ` [PATCH 4/7] virtio: console: Move code around for future patches Amit Shah
2010-03-23 8:57 ` [PATCH 5/7] virtio: console: Use a control message to add ports Amit Shah
2010-03-23 8:57 ` [PATCH 6/7] virtio: console: Don't always create a port 0 if using multiport Amit Shah
2010-03-23 8:58 ` [PATCH 7/7] virtio: console: Return -EPIPE if port on the host isn't connected Amit Shah
2010-03-23 9:00 ` Michael S. Tsirkin
2010-03-23 9:13 ` Amit Shah
2010-03-23 10:46 ` Gerd Hoffmann
2010-03-23 10:52 ` Amit Shah
2010-03-23 11:04 ` Gerd Hoffmann
2010-03-23 11:09 ` Amit Shah
2010-03-23 11:15 ` Gerd Hoffmann
2010-03-23 11:21 ` Amit Shah
2010-03-23 11:06 ` Amit Shah
2010-03-30 5:16 ` [PATCH 0/7] virtio: console: Fixes, new flexible way of discovering ports Rusty Russell
2010-03-30 5:20 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269334680-1369-4-git-send-email-amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).