virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Virtualization List <virtualization@lists.linux-foundation.org>
Cc: Amit Shah <amit.shah@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [PATCH 09/10] virtio: console: Rename wait_is_over() to will_read_block()
Date: Mon,  5 Apr 2010 19:24:13 +0530	[thread overview]
Message-ID: <1270475654-399-10-git-send-email-amit.shah@redhat.com> (raw)
In-Reply-To: <1270475654-399-9-git-send-email-amit.shah@redhat.com>

We'll introduce a function that checks if write will block.  Have
function names that are similar for the two cases.

Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
 drivers/char/virtio_console.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 3d70729..680ea25 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -486,9 +486,9 @@ static ssize_t fill_readbuf(struct port *port, char *out_buf, size_t out_count,
 }
 
 /* The condition that must be true for polling to end */
-static bool wait_is_over(struct port *port)
+static bool will_read_block(struct port *port)
 {
-	return port_has_data(port) || !port->host_connected;
+	return !port_has_data(port) && port->host_connected;
 }
 
 static ssize_t port_fops_read(struct file *filp, char __user *ubuf,
@@ -511,7 +511,7 @@ static ssize_t port_fops_read(struct file *filp, char __user *ubuf,
 			return -EAGAIN;
 
 		ret = wait_event_interruptible(port->waitqueue,
-					       wait_is_over(port));
+					       !will_read_block(port));
 		if (ret < 0)
 			return ret;
 	}
-- 
1.6.2.5

  reply	other threads:[~2010-04-05 13:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-05 13:54 [PATCH 00/10] (v5) virtio: console: Fixes, new way of discovering ports Amit Shah
2010-04-05 13:54 ` [PATCH 01/10] virtio: console: Add a __send_control_msg() that can send messages without a valid port Amit Shah
2010-04-05 13:54   ` [PATCH 02/10] virtio: console: Let host know of port or device add failures Amit Shah
2010-04-05 13:54     ` [PATCH 03/10] virtio: console: Return -EPIPE to hvc_console if we lost the connection Amit Shah
2010-04-05 13:54       ` [PATCH 04/10] virtio: console: Don't call hvc_remove() on unplugging console ports Amit Shah
2010-04-05 13:54         ` [PATCH 05/10] virtio: console: Remove config work handler Amit Shah
2010-04-05 13:54           ` [PATCH 06/10] virtio: console: Move code around for future patches Amit Shah
2010-04-05 13:54             ` [PATCH 07/10] virtio: console: Use a control message to add ports Amit Shah
2010-04-05 13:54               ` [PATCH 08/10] virtio: console: Don't always create a port 0 if using multiport Amit Shah
2010-04-05 13:54                 ` Amit Shah [this message]
2010-04-05 13:54                   ` [PATCH 10/10] virtio: console: Add support for nonblocking write()s Amit Shah
2010-04-06  3:12                     ` Rusty Russell
2010-04-06  3:54                       ` Amit Shah
2010-04-06 14:54                       ` Amit Shah
2010-04-06  3:09               ` [PATCH 07/10] virtio: console: Use a control message to add ports Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1270475654-399-10-git-send-email-amit.shah@redhat.com \
    --to=amit.shah@redhat.com \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).