From: Amit Shah <amit.shah@redhat.com>
To: Virtualization List <virtualization@lists.linux-foundation.org>
Cc: Amit Shah <amit.shah@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [PATCH 02/10] virtio: console: Let host know of port or device add failures
Date: Mon, 5 Apr 2010 19:24:06 +0530 [thread overview]
Message-ID: <1270475654-399-3-git-send-email-amit.shah@redhat.com> (raw)
In-Reply-To: <1270475654-399-2-git-send-email-amit.shah@redhat.com>
The host may want to know and let management apps notify of port or
device add failures. Send a control message saying the device or port is
not ready in this case.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
drivers/char/virtio_console.c | 5 +++++
include/linux/virtio_console.h | 3 +++
2 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 5d24015..1ae11f4 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -1217,6 +1217,8 @@ free_cdev:
free_port:
kfree(port);
fail:
+ /* The host might want to notify management sw about port add failure */
+ send_control_msg(port, VIRTIO_CONSOLE_PORT_READY, 0);
return err;
}
@@ -1495,6 +1497,9 @@ free_chrdev:
free:
kfree(portdev);
fail:
+ /* The host might want to notify mgmt sw about device add failure */
+ __send_control_msg(portdev, VIRTIO_CONSOLE_BAD_ID,
+ VIRTIO_CONSOLE_DEVICE_READY, 0);
return err;
}
diff --git a/include/linux/virtio_console.h b/include/linux/virtio_console.h
index ae4f039..0157361 100644
--- a/include/linux/virtio_console.h
+++ b/include/linux/virtio_console.h
@@ -14,6 +14,8 @@
#define VIRTIO_CONSOLE_F_SIZE 0 /* Does host provide console size? */
#define VIRTIO_CONSOLE_F_MULTIPORT 1 /* Does host provide multiple ports? */
+#define VIRTIO_CONSOLE_BAD_ID (~(u32)0)
+
struct virtio_console_config {
/* colums of the screens */
__u16 cols;
@@ -42,6 +44,7 @@ struct virtio_console_control {
#define VIRTIO_CONSOLE_PORT_OPEN 3
#define VIRTIO_CONSOLE_PORT_NAME 4
#define VIRTIO_CONSOLE_PORT_REMOVE 5
+#define VIRTIO_CONSOLE_DEVICE_READY 6
#ifdef __KERNEL__
int __init virtio_cons_early_init(int (*put_chars)(u32, const char *, int));
--
1.6.2.5
next prev parent reply other threads:[~2010-04-05 13:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 13:54 [PATCH 00/10] (v5) virtio: console: Fixes, new way of discovering ports Amit Shah
2010-04-05 13:54 ` [PATCH 01/10] virtio: console: Add a __send_control_msg() that can send messages without a valid port Amit Shah
2010-04-05 13:54 ` Amit Shah [this message]
2010-04-05 13:54 ` [PATCH 03/10] virtio: console: Return -EPIPE to hvc_console if we lost the connection Amit Shah
2010-04-05 13:54 ` [PATCH 04/10] virtio: console: Don't call hvc_remove() on unplugging console ports Amit Shah
2010-04-05 13:54 ` [PATCH 05/10] virtio: console: Remove config work handler Amit Shah
2010-04-05 13:54 ` [PATCH 06/10] virtio: console: Move code around for future patches Amit Shah
2010-04-05 13:54 ` [PATCH 07/10] virtio: console: Use a control message to add ports Amit Shah
2010-04-05 13:54 ` [PATCH 08/10] virtio: console: Don't always create a port 0 if using multiport Amit Shah
2010-04-05 13:54 ` [PATCH 09/10] virtio: console: Rename wait_is_over() to will_read_block() Amit Shah
2010-04-05 13:54 ` [PATCH 10/10] virtio: console: Add support for nonblocking write()s Amit Shah
2010-04-06 3:12 ` Rusty Russell
2010-04-06 3:54 ` Amit Shah
2010-04-06 14:54 ` Amit Shah
2010-04-06 3:09 ` [PATCH 07/10] virtio: console: Use a control message to add ports Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270475654-399-3-git-send-email-amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).