From: Amit Shah <amit.shah@redhat.com>
To: Virtualization List <virtualization@lists.linux-foundation.org>
Cc: Amit Shah <amit.shah@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [PATCH 03/10] virtio: console: Return -EPIPE to hvc_console if we lost the connection
Date: Mon, 5 Apr 2010 19:24:07 +0530 [thread overview]
Message-ID: <1270475654-399-4-git-send-email-amit.shah@redhat.com> (raw)
In-Reply-To: <1270475654-399-3-git-send-email-amit.shah@redhat.com>
hvc_console handles -EPIPE properly when the connection to the host is
lost.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
drivers/char/virtio_console.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 1ae11f4..733276d 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -660,7 +660,7 @@ static int put_chars(u32 vtermno, const char *buf, int count)
port = find_port_by_vtermno(vtermno);
if (!port)
- return 0;
+ return -EPIPE;
return send_buf(port, (void *)buf, count);
}
@@ -676,9 +676,13 @@ static int get_chars(u32 vtermno, char *buf, int count)
{
struct port *port;
+ /* If we've not set up the port yet, we have no input to give. */
+ if (unlikely(early_put_chars))
+ return 0;
+
port = find_port_by_vtermno(vtermno);
if (!port)
- return 0;
+ return -EPIPE;
/* If we don't have an input queue yet, we can't get input. */
BUG_ON(!port->in_vq);
--
1.6.2.5
next prev parent reply other threads:[~2010-04-05 13:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 13:54 [PATCH 00/10] (v5) virtio: console: Fixes, new way of discovering ports Amit Shah
2010-04-05 13:54 ` [PATCH 01/10] virtio: console: Add a __send_control_msg() that can send messages without a valid port Amit Shah
2010-04-05 13:54 ` [PATCH 02/10] virtio: console: Let host know of port or device add failures Amit Shah
2010-04-05 13:54 ` Amit Shah [this message]
2010-04-05 13:54 ` [PATCH 04/10] virtio: console: Don't call hvc_remove() on unplugging console ports Amit Shah
2010-04-05 13:54 ` [PATCH 05/10] virtio: console: Remove config work handler Amit Shah
2010-04-05 13:54 ` [PATCH 06/10] virtio: console: Move code around for future patches Amit Shah
2010-04-05 13:54 ` [PATCH 07/10] virtio: console: Use a control message to add ports Amit Shah
2010-04-05 13:54 ` [PATCH 08/10] virtio: console: Don't always create a port 0 if using multiport Amit Shah
2010-04-05 13:54 ` [PATCH 09/10] virtio: console: Rename wait_is_over() to will_read_block() Amit Shah
2010-04-05 13:54 ` [PATCH 10/10] virtio: console: Add support for nonblocking write()s Amit Shah
2010-04-06 3:12 ` Rusty Russell
2010-04-06 3:54 ` Amit Shah
2010-04-06 14:54 ` Amit Shah
2010-04-06 3:09 ` [PATCH 07/10] virtio: console: Use a control message to add ports Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270475654-399-4-git-send-email-amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).