virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Virtualization List <virtualization@lists.linux-foundation.org>
Cc: Amit Shah <amit.shah@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [PATCH 00/11] (v6) virtio: console: Fixes, new way of discovering ports
Date: Thu,  8 Apr 2010 20:19:29 +0530	[thread overview]
Message-ID: <1270738180-21170-1-git-send-email-amit.shah@redhat.com> (raw)

Hello,

This series reworks the ABI to allow port discovery (only) via the
control queue and enable multiport again.

In addition, it adds support for non-blocking write() support, which
means no spinning. This works fine with the recent patches that are on
qemu-devel.

Also included is removal of hvc_remove() as removing one such console
port causes other console ports (registered with hvc) to stall. This
has to be debugged in the hvc_console.c file, I'll do that later, but
we have a nice workaround for this: returning -EPIPE on any hvc
operations will make the hvc console core perform any cleanups for the
removed ports. Looks like we don't lose much by removing hvc_remove().

New in this version:
- Locking for the out_vq. Slightly changed version compared to the
  diff I sent earlier in that I don't lock inside
  reclaim_used_buffers() now, letting us use spin_lock_irq() instead
  of spin_lock_irqsave() from non-irq contexts.
- Remove extra line spotted by Rusty

Rusty, please apply for -next if all is well.

Amit Shah (11):
  Revert "virtio: disable multiport console support."
  virtio: console: Add a __send_control_msg() that can send messages
    without a valid port
  virtio: console: Let host know of port or device add failures
  virtio: console: Return -EPIPE to hvc_console if we lost the
    connection
  virtio: console: Don't call hvc_remove() on unplugging console ports
  virtio: console: Remove config work handler
  virtio: console: Move code around for future patches
  virtio: console: Use a control message to add ports
  virtio: console: Don't always create a port 0 if using multiport
  virtio: console: Rename wait_is_over() to will_read_block()
  virtio: console: Add support for nonblocking write()s

 drivers/char/virtio_console.c  |  605 ++++++++++++++++++++--------------------
 include/linux/virtio_console.h |   25 ++
 2 files changed, 334 insertions(+), 296 deletions(-)

             reply	other threads:[~2010-04-08 14:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08 14:49 Amit Shah [this message]
2010-04-08 14:49 ` [PATCH 01/11] Revert "virtio: disable multiport console support." Amit Shah
2010-04-08 14:49   ` [PATCH 02/11] virtio: console: Add a __send_control_msg() that can send messages without a valid port Amit Shah
2010-04-08 14:49     ` [PATCH 03/11] virtio: console: Let host know of port or device add failures Amit Shah
2010-04-08 14:49       ` [PATCH 04/11] virtio: console: Return -EPIPE to hvc_console if we lost the connection Amit Shah
2010-04-08 14:49         ` [PATCH 05/11] virtio: console: Don't call hvc_remove() on unplugging console ports Amit Shah
2010-04-08 14:49           ` [PATCH 06/11] virtio: console: Remove config work handler Amit Shah
2010-04-08 14:49             ` [PATCH 07/11] virtio: console: Move code around for future patches Amit Shah
2010-04-08 14:49               ` [PATCH 08/11] virtio: console: Use a control message to add ports Amit Shah
2010-04-08 14:49                 ` [PATCH 09/11] virtio: console: Don't always create a port 0 if using multiport Amit Shah
2010-04-08 14:49                   ` [PATCH 10/11] virtio: console: Rename wait_is_over() to will_read_block() Amit Shah
2010-04-08 14:49                     ` [PATCH 11/11] virtio: console: Add support for nonblocking write()s Amit Shah
2010-04-10  7:19                   ` [PATCH 09/11] virtio: console: Don't always create a port 0 if using multiport Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1270738180-21170-1-git-send-email-amit.shah@redhat.com \
    --to=amit.shah@redhat.com \
    --cc=mst@redhat.com \
    --cc=quintela@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).