From: Joe Perches <joe@perches.com>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"virtualization@lists.osdl.org" <virtualization@lists.osdl.org>,
"gregkh@suse.de" <gregkh@suse.de>,
Hank Janssen <hjanssen@microsoft.com>
Subject: RE: [PATCH 1/1] staging: hv: Add Time Sync feature to hv_utils module
Date: Wed, 05 May 2010 18:59:07 -0700 [thread overview]
Message-ID: <1273111147.1735.90.camel@Joe-Laptop.home> (raw)
In-Reply-To: <1FB5E1D5CA062146B38059374562DF72662A6F52@TK5EX14MBXC130.redmond.corp.microsoft.com>
On Thu, 2010-05-06 at 01:42 +0000, Haiyang Zhang wrote:
> > Why a maximum of 50 samples?
> After reboot the flag ICTIMESYNCFLAG_SYNC is included in the
> first time message after the timesync channel is opened. Since the
> hv_utils module is loaded after hv_vmbus, the first message is usually
> missed. The other thing is, systime is automatically set to emulated
> hardware clock which may not be UTC time or the same time
> zone. So, to override these effects, we use the first 50 time samples
> for initial system time setting.
I suggest putting that in a commit message or a code comment.
cheers, Joe
prev parent reply other threads:[~2010-05-06 1:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 19:23 [PATCH 1/1] staging: hv: Add Time Sync feature to hv_utils module Haiyang Zhang
2010-05-06 0:58 ` Joe Perches
2010-05-06 1:42 ` Haiyang Zhang
2010-05-06 1:59 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273111147.1735.90.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox