From: Joe Perches <joe@perches.com>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'devel@driverdev.osuosl.org'" <devel@driverdev.osuosl.org>,
"'virtualization@lists.osdl.org'" <virtualization@lists.osdl.org>,
"'gregkh@suse.de'" <gregkh@suse.de>
Subject: Re: [PATCH 1/1] Rename camel case variables in channel.c (updated)
Date: Thu, 23 Sep 2010 15:38:06 -0700 [thread overview]
Message-ID: <1285281486.25928.31.camel@Joe-Laptop> (raw)
In-Reply-To: <1FB5E1D5CA062146B38059374562DF7289ED89CF@TK5EX14MBXC130.redmond.corp.microsoft.com>
On Thu, 2010-09-23 at 22:04 +0000, Haiyang Zhang wrote:
> From: Haiyang Zhang <haiyangz@microsoft.com>
>
> Rename camel case variables in channel.c
[]
> -static int VmbusChannelCreateGpadlHeader(void *Kbuffer, u32 Size,
> - struct vmbus_channel_msginfo **MsgInfo,
> - u32 *MessageCount)
> +static int VmbusChannelCreateGpadlHeader(void *kbuffer, u32 size,
> + struct vmbus_channel_msginfo **msginfo,
> + u32 *messagecount)
> {
> int i;
> - int pageCount;
> + int pagecount;
> unsigned long long pfn;
> - struct vmbus_channel_gpadl_header *gpaHeader;
> - struct vmbus_channel_gpadl_body *gpadlBody;
> - struct vmbus_channel_msginfo *msgHeader;
> - struct vmbus_channel_msginfo *msgBody = NULL;
> - u32 msgSize;
> + struct vmbus_channel_gpadl_header *gpal_header;
> + struct vmbus_channel_gpadl_body *gpadl_body;
> + struct vmbus_channel_msginfo *msgheader;
> + struct vmbus_channel_msginfo *msgbody = NULL;
> + u32 msgsize;
Why gpal_header and not gpadl_header?
I didn't read farther.
next parent reply other threads:[~2010-09-23 22:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1FB5E1D5CA062146B38059374562DF7289ED89CF@TK5EX14MBXC130.redmond.corp.microsoft.com>
2010-09-23 22:38 ` Joe Perches [this message]
2010-09-24 16:08 ` [PATCH 1/1] Rename camel case variables in channel.c (updated) Haiyang Zhang
2010-09-24 16:06 ` [PATCH 1/1] Rename camel case variables in channel.c (updated again) Haiyang Zhang
[not found] ` <1FB5E1D5CA062146B38059374562DF7289EDBC9E@TK5EX14MBXC130.redmond.corp.microsoft.com>
2010-09-24 17:29 ` Joe Perches
2010-09-27 1:19 ` Greg KH
2010-09-27 2:52 ` Haiyang Zhang
2010-09-27 6:10 ` Greg KH
2010-09-27 17:57 ` Haiyang Zhang
2010-09-27 19:32 ` Greg KH
2010-09-27 22:59 ` Haiyang Zhang
2010-09-28 1:25 ` Greg KH
2010-09-23 22:04 [PATCH 1/1] Rename camel case variables in channel.c (updated) Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285281486.25928.31.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).