From: Peter Zijlstra <peterz@infradead.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Xen-devel <xen-devel@lists.xensource.com>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Srivatsa@smtp1.linux-foundation.org,
Linux@smtp1.linux-foundation.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jan Beulich <JBeulich@novell.com>,
Virtualization <virtualization@lists.linux-foundation.org>,
Vaddagiri <vatsa@linux.vnet.ibm.com>, Kivity <avi@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Avi@smtp1.linux-foundation.org
Subject: Re: [PATCH 00/20] x86: ticket lock rewrite and paravirtualization
Date: Mon, 15 Nov 2010 22:08:32 +0100 [thread overview]
Message-ID: <1289855312.2109.555.camel@laptop> (raw)
In-Reply-To: <4CE19FD1.2000804@goop.org>
On Mon, 2010-11-15 at 13:02 -0800, Jeremy Fitzhardinge wrote:
>
> As a heuristic, it shouldn't be too bad performancewise, since
> (handwaving) if ticketholder N has entered the slowpath, then its likely
> that N+1 will as well.
Yes, esp. if the whole slow unlock path takes more cycles than you spin
for to begin with.
I think this approach is definitely worth trying.
next prev parent reply other threads:[~2010-11-15 21:08 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1288794124.git.jeremy.fitzhardinge@citrix.com>
2010-11-03 14:59 ` [PATCH 01/20] x86/ticketlock: clean up types and accessors Jeremy Fitzhardinge
2010-11-03 14:59 ` [PATCH 02/20] x86/ticketlock: convert spin loop to C Jeremy Fitzhardinge
2010-11-03 14:59 ` [PATCH 03/20] x86/ticketlock: Use C for __ticket_spin_unlock Jeremy Fitzhardinge
2010-11-03 14:59 ` [PATCH 04/20] x86/ticketlock: make large and small ticket versions of spin_lock the same Jeremy Fitzhardinge
2010-11-03 14:59 ` [PATCH 05/20] x86/ticketlock: make __ticket_spin_lock common Jeremy Fitzhardinge
2010-11-03 14:59 ` [PATCH 06/20] x86/ticketlock: make __ticket_spin_trylock common Jeremy Fitzhardinge
2010-11-03 14:59 ` [PATCH 07/20] x86/spinlocks: replace pv spinlocks with pv ticketlocks Jeremy Fitzhardinge
2010-11-03 14:59 ` [PATCH 08/20] x86/ticketlock: collapse a layer of functions Jeremy Fitzhardinge
2010-11-03 14:59 ` [PATCH 09/20] xen/pvticketlock: Xen implementation for PV ticket locks Jeremy Fitzhardinge
2010-11-03 14:59 ` [PATCH 10/20] x86/pvticketlock: keep count of blocked cpus Jeremy Fitzhardinge
2010-11-03 14:59 ` [PATCH 11/20] x86/pvticketlock: use callee-save for lock_spinning Jeremy Fitzhardinge
2010-11-03 14:59 ` [PATCH 12/20] x86/pvticketlock: use callee-save for unlock_kick as well Jeremy Fitzhardinge
2010-11-03 14:59 ` [PATCH 13/20] x86/pvticketlock: make sure unlock is seen by everyone before checking waiters Jeremy Fitzhardinge
2010-11-03 14:59 ` [PATCH 14/20] x86/ticketlock: loosen ordering restraints on unlock Jeremy Fitzhardinge
2010-11-03 14:59 ` [PATCH 15/20] x86/ticketlock: prevent compiler reordering into locked region Jeremy Fitzhardinge
2010-11-03 14:59 ` [PATCH 16/20] x86/ticketlock: don't inline _spin_unlock when using paravirt spinlocks Jeremy Fitzhardinge
2010-11-03 14:59 ` [PATCH 17/20] x86/ticketlock: clarify barrier in arch_spin_lock Jeremy Fitzhardinge
2010-11-03 14:59 ` [PATCH 18/20] x86/ticketlock: remove .slock Jeremy Fitzhardinge
2010-11-03 15:00 ` [PATCH 19/20] x86/ticketlocks: use overlapping read to eliminate mb() Jeremy Fitzhardinge
2010-11-03 15:00 ` [PATCH 20/20] x86/ticketlock: rename ticketpair to head_tail Jeremy Fitzhardinge
[not found] ` <3d9083892c28a7d3ed5a0191b0b4cd013022a186.1288794124.git.jeremy.fitzhardinge@citrix.com>
2010-11-03 15:11 ` [PATCH 02/20] x86/ticketlock: convert spin loop to C Eric Dumazet
[not found] ` <1288797092.2511.141.camel@edumazet-laptop>
2010-11-03 15:38 ` Jeremy Fitzhardinge
[not found] ` <20092775a9df07a5a75820ac250194b535279d51.1288794124.git.jeremy.fitzhardinge@citrix.com>
2010-11-03 15:13 ` [PATCH 03/20] x86/ticketlock: Use C for __ticket_spin_unlock Eric Dumazet
[not found] ` <1288797218.2511.143.camel@edumazet-laptop>
2010-11-03 18:00 ` Jeremy Fitzhardinge
2010-11-13 10:05 ` Américo Wang
[not found] ` <20101113100527.GG3837@hack>
2010-11-13 22:34 ` Paolo Bonzini
2010-11-15 19:38 ` Jeremy Fitzhardinge
[not found] ` <5b3cbff3a6e96a085651f140a0525be80a4df8ba.1288794124.git.jeremy.fitzhardinge@citrix.com>
2010-11-12 12:19 ` [PATCH 04/20] x86/ticketlock: make large and small ticket versions of spin_lock the same Srivatsa Vaddagiri
[not found] ` <20101112121932.GA30016@linux.vnet.ibm.com>
2010-11-12 16:27 ` Jeremy Fitzhardinge
2010-11-12 22:12 ` [PATCH 00/20] x86: ticket lock rewrite and paravirtualization H. Peter Anvin
2010-11-12 22:17 ` Jeremy Fitzhardinge
[not found] ` <4CDDBCE4.80906@goop.org>
2010-11-12 22:20 ` H. Peter Anvin
2010-11-15 20:00 ` Jeremy Fitzhardinge
[not found] ` <4CE1915F.60507@goop.org>
2010-11-15 20:03 ` H. Peter Anvin
[not found] ` <4CE1920F.5000509@zytor.com>
2010-11-15 20:14 ` Peter Zijlstra
[not found] ` <1289852088.2109.553.camel@laptop>
2010-11-15 21:02 ` Jeremy Fitzhardinge
[not found] ` <4CE19FD1.2000804@goop.org>
2010-11-15 21:08 ` Peter Zijlstra [this message]
[not found] ` <742be99eb6d64784dbc3e446d22df78b7a55fc0c.1288794124.git.jeremy.fitzhardinge@citrix.com>
2010-11-13 9:57 ` [PATCH 01/20] x86/ticketlock: clean up types and accessors Américo Wang
[not found] ` <20101113095732.GF3837@hack>
2010-11-15 19:36 ` Jeremy Fitzhardinge
[not found] ` <4cea7b0804de5a2c1249034fc5c4840ade043ff4.1288794124.git.jeremy.fitzhardinge@citrix.com>
2010-11-13 10:17 ` [PATCH 06/20] x86/ticketlock: make __ticket_spin_trylock common Américo Wang
[not found] ` <20101113101732.GH3837@hack>
2010-11-13 10:48 ` Eric Dumazet
[not found] ` <1289645321.2743.21.camel@edumazet-laptop>
2010-11-15 19:39 ` Jeremy Fitzhardinge
2010-11-03 14:59 [PATCH 00/20] x86: ticket lock rewrite and paravirtualization Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289855312.2109.555.camel@laptop \
--to=peterz@infradead.org \
--cc=Avi@smtp1.linux-foundation.org \
--cc=JBeulich@novell.com \
--cc=Linux@smtp1.linux-foundation.org \
--cc=Srivatsa@smtp1.linux-foundation.org \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=vatsa@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).