From: Joe Perches <joe@perches.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, virtualization@lists.osdl.org,
Haiyang Zhang <haiyangz@microsoft.com>
Subject: Re: [PATCH 5/8] Staging: hv: mousevsc: Fix checkpatch errors and warnings
Date: Tue, 19 Jul 2011 12:28:33 -0700 [thread overview]
Message-ID: <1311103713.12882.13.camel@Joe-Laptop> (raw)
In-Reply-To: <1311101065-23417-5-git-send-email-kys@microsoft.com>
On Tue, 2011-07-19 at 11:44 -0700, K. Y. Srinivasan wrote:
> Fix checkpatch errors and warnings.
[]
> diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
[]
> @@ -53,7 +53,7 @@ struct hv_input_dev_info {
> -#pragma pack(push,1)
> +#pragma pack(push, 1)
> /*
> * Message types in the synthetic input protocol
> */
Perhaps it's better and more consistent with
other kernel style uses to remove #pragma pack[...]
and mark the individual structs with __packed;
$ grep -rP --include=*.[ch] "pragma.*pack" * | wc -l
221
$ grep -rP --include=*.[ch] "(__attribute__.*packed|\b__packed\b)" * | wc -l
5553
next prev parent reply other threads:[~2011-07-19 19:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 18:43 [PATCH 0/8] Staging: hv: Driver cleanup K. Y. Srinivasan
2011-07-19 18:44 ` [PATCH 1/8] Staging: hv: vmbus: Fix a checkpatch warning in ring_buffer.c K. Y. Srinivasan
2011-07-19 18:44 ` [PATCH 2/8] Staging: hv: vmbus: Fix checkpatch warnings in connection.c K. Y. Srinivasan
2011-07-19 18:44 ` [PATCH 3/8] Staging: hv: tools: Fix a checkpatch warning in hv_kvp_daemon.c K. Y. Srinivasan
2011-07-19 18:44 ` [PATCH 4/8] Staging: hv: vmbus: Fix checkpatch warnings K. Y. Srinivasan
2011-08-23 23:16 ` Greg KH
2011-08-24 1:10 ` KY Srinivasan
2011-07-19 18:44 ` [PATCH 5/8] Staging: hv: mousevsc: Fix checkpatch errors and warnings K. Y. Srinivasan
2011-07-19 19:28 ` Joe Perches [this message]
2011-07-19 22:46 ` KY Srinivasan
2011-07-19 18:44 ` [PATCH 6/8] Staging: hv: Get rid of checkpatch cleanup item K. Y. Srinivasan
2011-07-19 18:44 ` [PATCH 7/8] Staging: hv: Get rid of the vmbus merge item K. Y. Srinivasan
2011-07-19 18:44 ` [PATCH 8/8] Staging: hv: Update the TODO file K. Y. Srinivasan
2011-08-23 23:14 ` [PATCH 1/8] Staging: hv: vmbus: Fix a checkpatch warning in ring_buffer.c Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311103713.12882.13.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).