From: Joe Perches <joe@perches.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, virtualization@lists.osdl.org,
Haiyang Zhang <haiyangz@microsoft.com>
Subject: Re: [PATCH 1/3] Staging: hv: util: Perform some service specific init/deinit in probe/remove
Date: Sun, 18 Sep 2011 10:53:13 -0700 [thread overview]
Message-ID: <1316368394.4916.2.camel@Joe-Laptop> (raw)
In-Reply-To: <1316367095-739-1-git-send-email-kys@microsoft.com>
On Sun, 2011-09-18 at 10:31 -0700, K. Y. Srinivasan wrote:
> In preparation for modifying the util driver to fully conform to the
> Linux Driver Model,
[]
> diff --git a/drivers/staging/hv/hv_util.c b/drivers/staging/hv/hv_util.c
[]
> static const struct hv_vmbus_device_id id_table[] = {
> /* Shutdown guid */
> { VMBUS_DEVICE(0x31, 0x60, 0x0B, 0X0E, 0x13, 0x52, 0x34, 0x49,
> - 0x81, 0x8B, 0x38, 0XD9, 0x0C, 0xED, 0x39, 0xDB) },
> + 0x81, 0x8B, 0x38, 0XD9, 0x0C, 0xED, 0x39, 0xDB)
> + .driver_data = (unsigned long)&util_shutdown },
Isn't this a kernel_ulong_t ?
> + .driver_data = (unsigned long)&util_timesynch },
etc.
next prev parent reply other threads:[~2011-09-18 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-18 17:30 [PATCH 0000/0003] Staging: hv: Driver cleanup K. Y. Srinivasan
2011-09-18 17:31 ` [PATCH 1/3] Staging: hv: util: Perform some service specific init/deinit in probe/remove K. Y. Srinivasan
2011-09-18 17:31 ` [PATCH 2/3] Staging: hv: util: Properly handle util services in the util driver K. Y. Srinivasan
2011-09-18 17:31 ` [PATCH 3/3] Staging: hv: vmbus: Get rid of hv_cb_utils[] and other unneeded code K. Y. Srinivasan
2011-09-18 17:53 ` Joe Perches [this message]
2011-09-18 22:26 ` [PATCH 1/3] Staging: hv: util: Perform some service specific init/deinit in probe/remove KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316368394.4916.2.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).