* Re: [PATCH] staging: hv: move hv_netvsc out of staging area
2011-10-14 19:20 [PATCH] staging: hv: move hv_netvsc out of staging area Haiyang Zhang
@ 2011-10-14 19:12 ` Stephen Hemminger
2011-10-14 19:16 ` Greg KH
2011-10-14 19:35 ` Sasha Levin
2 siblings, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2011-10-14 19:12 UTC (permalink / raw)
To: Haiyang Zhang
Cc: kys, gregkh, linux-kernel, devel, virtualization, Mike Sterling,
NetDev
On Fri, 14 Oct 2011 12:20:26 -0700
Haiyang Zhang <haiyangz@microsoft.com> wrote:
> hv_netvsc has been reviewed on netdev mailing list on 6/09/2011.
> All recommended changes have been made. We are requesting to move
> it out of staging area.
>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Signed-off-by: KY Srinivasan <kys@microsoft.com>
> Signed-off-by: Mike Sterling <Mike.Sterling@microsoft.com>
> Cc: NetDev <netdev@vger.kernel.org>
Thanks for all the work.
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: hv: move hv_netvsc out of staging area
2011-10-14 19:20 [PATCH] staging: hv: move hv_netvsc out of staging area Haiyang Zhang
2011-10-14 19:12 ` Stephen Hemminger
@ 2011-10-14 19:16 ` Greg KH
2011-10-14 19:28 ` Haiyang Zhang
2011-10-14 19:35 ` Sasha Levin
2 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2011-10-14 19:16 UTC (permalink / raw)
To: Haiyang Zhang
Cc: kys, linux-kernel, devel, virtualization, Mike Sterling, NetDev
On Fri, Oct 14, 2011 at 12:20:26PM -0700, Haiyang Zhang wrote:
> hv_netvsc has been reviewed on netdev mailing list on 6/09/2011.
> All recommended changes have been made. We are requesting to move
> it out of staging area.
>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Signed-off-by: KY Srinivasan <kys@microsoft.com>
> Signed-off-by: Mike Sterling <Mike.Sterling@microsoft.com>
> Cc: NetDev <netdev@vger.kernel.org>
>
> ---
> drivers/net/Kconfig | 2 ++
> drivers/net/Makefile | 2 ++
> drivers/net/hyperv/Kconfig | 5 +++++
> drivers/net/hyperv/Makefile | 3 +++
> drivers/{staging/hv => net/hyperv}/hyperv_net.h | 0
> drivers/{staging/hv => net/hyperv}/netvsc.c | 0
> drivers/{staging/hv => net/hyperv}/netvsc_drv.c | 0
> drivers/{staging/hv => net/hyperv}/rndis_filter.c | 0
Because of renames, the network developers really can't review this. I
suggest posting a new patch, that just adds the driver to the
drivers/net/ directory, and have the network developer review it that
way.
Then, when it is accepted, I can delete the version in the staging
directory. We've done it this way for other drivers and it is the best
way to get proper reviews as well as handling cross-subsystem merge
issues.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging: hv: move hv_netvsc out of staging area
@ 2011-10-14 19:20 Haiyang Zhang
2011-10-14 19:12 ` Stephen Hemminger
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Haiyang Zhang @ 2011-10-14 19:20 UTC (permalink / raw)
To: haiyangz, kys, gregkh, linux-kernel, devel, virtualization
Cc: Mike Sterling, NetDev
hv_netvsc has been reviewed on netdev mailing list on 6/09/2011.
All recommended changes have been made. We are requesting to move
it out of staging area.
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: KY Srinivasan <kys@microsoft.com>
Signed-off-by: Mike Sterling <Mike.Sterling@microsoft.com>
Cc: NetDev <netdev@vger.kernel.org>
---
drivers/net/Kconfig | 2 ++
drivers/net/Makefile | 2 ++
drivers/net/hyperv/Kconfig | 5 +++++
drivers/net/hyperv/Makefile | 3 +++
drivers/{staging/hv => net/hyperv}/hyperv_net.h | 0
drivers/{staging/hv => net/hyperv}/netvsc.c | 0
drivers/{staging/hv => net/hyperv}/netvsc_drv.c | 0
drivers/{staging/hv => net/hyperv}/rndis_filter.c | 0
drivers/staging/hv/Kconfig | 6 ------
drivers/staging/hv/Makefile | 2 --
drivers/staging/hv/TODO | 1 -
11 files changed, 12 insertions(+), 9 deletions(-)
create mode 100644 drivers/net/hyperv/Kconfig
create mode 100644 drivers/net/hyperv/Makefile
rename drivers/{staging/hv => net/hyperv}/hyperv_net.h (100%)
rename drivers/{staging/hv => net/hyperv}/netvsc.c (100%)
rename drivers/{staging/hv => net/hyperv}/netvsc_drv.c (100%)
rename drivers/{staging/hv => net/hyperv}/rndis_filter.c (100%)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 8d0314d..088c330 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -3451,4 +3451,6 @@ config VMXNET3
To compile this driver as a module, choose M here: the
module will be called vmxnet3.
+source "drivers/net/hyperv/Kconfig"
+
endif # NETDEVICES
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index e1eca2a..647c878 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -306,3 +306,5 @@ obj-$(CONFIG_CAIF) += caif/
obj-$(CONFIG_OCTEON_MGMT_ETHERNET) += octeon/
obj-$(CONFIG_PCH_GBE) += pch_gbe/
obj-$(CONFIG_TILE_NET) += tile/
+
+obj-$(CONFIG_HYPERV_NET) += hyperv/
diff --git a/drivers/net/hyperv/Kconfig b/drivers/net/hyperv/Kconfig
new file mode 100644
index 0000000..936968d
--- /dev/null
+++ b/drivers/net/hyperv/Kconfig
@@ -0,0 +1,5 @@
+config HYPERV_NET
+ tristate "Microsoft Hyper-V virtual network driver"
+ depends on HYPERV
+ help
+ Select this option to enable the Hyper-V virtual network driver.
diff --git a/drivers/net/hyperv/Makefile b/drivers/net/hyperv/Makefile
new file mode 100644
index 0000000..c8a6682
--- /dev/null
+++ b/drivers/net/hyperv/Makefile
@@ -0,0 +1,3 @@
+obj-$(CONFIG_HYPERV_NET) += hv_netvsc.o
+
+hv_netvsc-y := netvsc_drv.o netvsc.o rndis_filter.o
diff --git a/drivers/staging/hv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h
similarity index 100%
rename from drivers/staging/hv/hyperv_net.h
rename to drivers/net/hyperv/hyperv_net.h
diff --git a/drivers/staging/hv/netvsc.c b/drivers/net/hyperv/netvsc.c
similarity index 100%
rename from drivers/staging/hv/netvsc.c
rename to drivers/net/hyperv/netvsc.c
diff --git a/drivers/staging/hv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
similarity index 100%
rename from drivers/staging/hv/netvsc_drv.c
rename to drivers/net/hyperv/netvsc_drv.c
diff --git a/drivers/staging/hv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
similarity index 100%
rename from drivers/staging/hv/rndis_filter.c
rename to drivers/net/hyperv/rndis_filter.c
diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
index 072185e..8a51166 100644
--- a/drivers/staging/hv/Kconfig
+++ b/drivers/staging/hv/Kconfig
@@ -4,12 +4,6 @@ config HYPERV_STORAGE
help
Select this option to enable the Hyper-V virtual storage driver.
-config HYPERV_NET
- tristate "Microsoft Hyper-V virtual network driver"
- depends on HYPERV && NET
- help
- Select this option to enable the Hyper-V virtual network driver.
-
config HYPERV_MOUSE
tristate "Microsoft Hyper-V mouse driver"
depends on HYPERV && HID
diff --git a/drivers/staging/hv/Makefile b/drivers/staging/hv/Makefile
index e071c12..b536584 100644
--- a/drivers/staging/hv/Makefile
+++ b/drivers/staging/hv/Makefile
@@ -1,7 +1,5 @@
obj-$(CONFIG_HYPERV) += hv_timesource.o
obj-$(CONFIG_HYPERV_STORAGE) += hv_storvsc.o
-obj-$(CONFIG_HYPERV_NET) += hv_netvsc.o
obj-$(CONFIG_HYPERV_MOUSE) += hv_mouse.o
hv_storvsc-y := storvsc_drv.o
-hv_netvsc-y := netvsc_drv.o netvsc.o rndis_filter.o
diff --git a/drivers/staging/hv/TODO b/drivers/staging/hv/TODO
index ed4d636..fd080cb 100644
--- a/drivers/staging/hv/TODO
+++ b/drivers/staging/hv/TODO
@@ -1,5 +1,4 @@
TODO:
- - audit the network driver
- audit the scsi driver
Please send patches for this code to Greg Kroah-Hartman <gregkh@suse.de>,
--
1.7.3.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] staging: hv: move hv_netvsc out of staging area
2011-10-14 19:16 ` Greg KH
@ 2011-10-14 19:28 ` Haiyang Zhang
0 siblings, 0 replies; 6+ messages in thread
From: Haiyang Zhang @ 2011-10-14 19:28 UTC (permalink / raw)
To: Greg KH
Cc: NetDev, linux-kernel@vger.kernel.org,
virtualization@lists.osdl.org, Mike Sterling,
devel@linuxdriverproject.org
> -----Original Message-----
> From: Greg KH [mailto:gregkh@suse.de]
> Sent: Friday, October 14, 2011 3:16 PM
> Because of renames, the network developers really can't review this.
> I
> suggest posting a new patch, that just adds the driver to the
> drivers/net/ directory, and have the network developer review it that
> way.
>
> Then, when it is accepted, I can delete the version in the staging
> directory. We've done it this way for other drivers and it is the
> best
> way to get proper reviews as well as handling cross-subsystem merge
> issues.
During the previous review in June, Joe Perches suggested me to use -M
option to show only changed code. But I will make a new patch to show
all code according to your request.
Thanks,
- Haiyang
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: hv: move hv_netvsc out of staging area
2011-10-14 19:20 [PATCH] staging: hv: move hv_netvsc out of staging area Haiyang Zhang
2011-10-14 19:12 ` Stephen Hemminger
2011-10-14 19:16 ` Greg KH
@ 2011-10-14 19:35 ` Sasha Levin
2011-10-14 19:40 ` Haiyang Zhang
2 siblings, 1 reply; 6+ messages in thread
From: Sasha Levin @ 2011-10-14 19:35 UTC (permalink / raw)
To: Haiyang Zhang
Cc: NetDev, gregkh, linux-kernel, virtualization, Mike Sterling,
devel
On Fri, 2011-10-14 at 12:20 -0700, Haiyang Zhang wrote:
> hv_netvsc has been reviewed on netdev mailing list on 6/09/2011.
> All recommended changes have been made. We are requesting to move
> it out of staging area.
>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Signed-off-by: KY Srinivasan <kys@microsoft.com>
> Signed-off-by: Mike Sterling <Mike.Sterling@microsoft.com>
> Cc: NetDev <netdev@vger.kernel.org>
>
> ---
> drivers/net/Kconfig | 2 ++
> drivers/net/Makefile | 2 ++
> drivers/net/hyperv/Kconfig | 5 +++++
> drivers/net/hyperv/Makefile | 3 +++
> drivers/{staging/hv => net/hyperv}/hyperv_net.h | 0
> drivers/{staging/hv => net/hyperv}/netvsc.c | 0
> drivers/{staging/hv => net/hyperv}/netvsc_drv.c | 0
> drivers/{staging/hv => net/hyperv}/rndis_filter.c | 0
> drivers/staging/hv/Kconfig | 6 ------
> drivers/staging/hv/Makefile | 2 --
> drivers/staging/hv/TODO | 1 -
> 11 files changed, 12 insertions(+), 9 deletions(-)
> create mode 100644 drivers/net/hyperv/Kconfig
> create mode 100644 drivers/net/hyperv/Makefile
> rename drivers/{staging/hv => net/hyperv}/hyperv_net.h (100%)
> rename drivers/{staging/hv => net/hyperv}/netvsc.c (100%)
> rename drivers/{staging/hv => net/hyperv}/netvsc_drv.c (100%)
> rename drivers/{staging/hv => net/hyperv}/rndis_filter.c (100%)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 8d0314d..088c330 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -3451,4 +3451,6 @@ config VMXNET3
> To compile this driver as a module, choose M here: the
> module will be called vmxnet3.
>
> +source "drivers/net/hyperv/Kconfig"
> +
> endif # NETDEVICES
> diff --git a/drivers/net/Makefile b/drivers/net/Makefile
> index e1eca2a..647c878 100644
> --- a/drivers/net/Makefile
> +++ b/drivers/net/Makefile
> @@ -306,3 +306,5 @@ obj-$(CONFIG_CAIF) += caif/
> obj-$(CONFIG_OCTEON_MGMT_ETHERNET) += octeon/
> obj-$(CONFIG_PCH_GBE) += pch_gbe/
> obj-$(CONFIG_TILE_NET) += tile/
> +
> +obj-$(CONFIG_HYPERV_NET) += hyperv/
> diff --git a/drivers/net/hyperv/Kconfig b/drivers/net/hyperv/Kconfig
> new file mode 100644
> index 0000000..936968d
> --- /dev/null
> +++ b/drivers/net/hyperv/Kconfig
> @@ -0,0 +1,5 @@
> +config HYPERV_NET
> + tristate "Microsoft Hyper-V virtual network driver"
> + depends on HYPERV
It doesn't depend on NET anymore?
--
Sasha.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] staging: hv: move hv_netvsc out of staging area
2011-10-14 19:35 ` Sasha Levin
@ 2011-10-14 19:40 ` Haiyang Zhang
0 siblings, 0 replies; 6+ messages in thread
From: Haiyang Zhang @ 2011-10-14 19:40 UTC (permalink / raw)
To: Sasha Levin
Cc: KY Srinivasan, gregkh@suse.de, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, virtualization@lists.osdl.org,
Mike Sterling, NetDev
> -----Original Message-----
> From: Sasha Levin [mailto:levinsasha928@gmail.com]
> Sent: Friday, October 14, 2011 3:36 PM
> > +
> > +obj-$(CONFIG_HYPERV_NET) += hyperv/
> > diff --git a/drivers/net/hyperv/Kconfig b/drivers/net/hyperv/Kconfig
> > new file mode 100644
> > index 0000000..936968d
> > --- /dev/null
> > +++ b/drivers/net/hyperv/Kconfig
> > @@ -0,0 +1,5 @@
> > +config HYPERV_NET
> > + tristate "Microsoft Hyper-V virtual network driver"
> > + depends on HYPERV
>
> It doesn't depend on NET anymore?
All drivers in drivers/net depends on NET, which is handled by net/Kconfig
already. So we don't need to duplicate the dependency. (suggested by Randy
Dunlap <randy.dunlap@oracle.com> in last review.)
Thanks,
- Haiyang
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-10-14 19:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-14 19:20 [PATCH] staging: hv: move hv_netvsc out of staging area Haiyang Zhang
2011-10-14 19:12 ` Stephen Hemminger
2011-10-14 19:16 ` Greg KH
2011-10-14 19:28 ` Haiyang Zhang
2011-10-14 19:35 ` Sasha Levin
2011-10-14 19:40 ` Haiyang Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).