From: "K. Y. Srinivasan" <kys@microsoft.com>
To: gregkh@suse.de, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, virtualization@lists.osdl.org,
ohering@suse.com, James.Bottomley@HansenPartnership.com,
hch@infradead.org, linux-scsi@vger.kernel.org
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>
Subject: [PATCH 3/5] Staging: hv: storvsc: Fix a bug in storvsc_command_completion()
Date: Thu, 1 Dec 2011 04:59:18 -0800 [thread overview]
Message-ID: <1322744360-13067-3-git-send-email-kys@microsoft.com> (raw)
In-Reply-To: <1322744360-13067-1-git-send-email-kys@microsoft.com>
Fix a bug in storvsc_command_completion() that leaks memory when scatter/gather
lists are used on the "write" side.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
---
drivers/staging/hv/storvsc_drv.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c
index 14ecb69..8dafe52 100644
--- a/drivers/staging/hv/storvsc_drv.c
+++ b/drivers/staging/hv/storvsc_drv.c
@@ -1123,13 +1123,12 @@ static void storvsc_command_completion(struct hv_storvsc_request *request)
vm_srb = &request->vstor_packet.vm_srb;
if (cmd_request->bounce_sgl_count) {
- if (vm_srb->data_in == READ_TYPE) {
+ if (vm_srb->data_in == READ_TYPE)
copy_from_bounce_buffer(scsi_sglist(scmnd),
cmd_request->bounce_sgl,
scsi_sg_count(scmnd));
- destroy_bounce_buffer(cmd_request->bounce_sgl,
+ destroy_bounce_buffer(cmd_request->bounce_sgl,
cmd_request->bounce_sgl_count);
- }
}
/*
--
1.7.4.1
next prev parent reply other threads:[~2011-12-01 12:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 12:58 [PATCH 0000/0005] Staging: hv: storvsc cleanup K. Y. Srinivasan
2011-12-01 12:59 ` [PATCH 1/5] Staging: hv: storvsc: Disable clustering K. Y. Srinivasan
2011-12-01 12:59 ` [PATCH 2/5] Staging: hv: storvsc: Cleanup storvsc_device_alloc() K. Y. Srinivasan
2011-12-01 12:59 ` K. Y. Srinivasan [this message]
2011-12-01 12:59 ` [PATCH 4/5] Staging: hv: storvsc: Fix a bug in copy_from_bounce_buffer() K. Y. Srinivasan
2011-12-01 21:03 ` Dan Carpenter
2011-12-01 21:07 ` KY Srinivasan
2011-12-01 21:11 ` Dan Carpenter
2011-12-01 21:13 ` KY Srinivasan
2011-12-01 12:59 ` [PATCH 5/5] Staging: hv: storvsc: Implement per device memory pools K. Y. Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322744360-13067-3-git-send-email-kys@microsoft.com \
--to=kys@microsoft.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ohering@suse.com \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).