From: Pawel Moll <pawel.moll@arm.com>
To: Paul Brook <paul@codesourcery.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
virtualization@lists.linux-foundation.org,
Anthony Liguori <anthony@codemonkey.ws>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [RFC 0/4] virtio-mmio transport
Date: Mon, 12 Dec 2011 11:16:19 +0000 [thread overview]
Message-ID: <1323688579.2391.11.camel@hornet.cambridge.arm.com> (raw)
In-Reply-To: <201112120252.35295.paul@codesourcery.com>
On Mon, 2011-12-12 at 02:52 +0000, Paul Brook wrote:
> I've taken a look at the virtion-mmio spec, and it looks fairly
> reasonable.
>
> The only thing I'd change is the GuestPageSize/QueuePFN mess. Seems like just
> using straight 64-bit addresses would be a better solution. Maybe split into
> a high/low pair to keep all registers as 32-bit registers.
This can be done fairly simple by:
1. Bumping Version register content.
2. Adding two registers: QueueAddrLow (0x44) and QueueAddrHigh (0x48).
3. Describing the QueuePFN as obsolete.
Than the driver would just use Addr or PFN depending on the device's
version.
I can do that, but not this year (on holiday from Friday 16th, without
any access to Internet whatsoever :-) One think to be decided is in what
order the halfs should be filled? Low first, then high? High then low?
Does it matter at all? :-)
Cheers!
Paweł
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next parent reply other threads:[~2011-12-12 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1321282528-19070-1-git-send-email-peter.maydell@linaro.org>
[not found] ` <201112091516.07644.paul@codesourcery.com>
[not found] ` <4EE22FF4.5050903@codemonkey.ws>
[not found] ` <201112120252.35295.paul@codesourcery.com>
2011-12-12 11:16 ` Pawel Moll [this message]
2011-12-12 14:45 ` [Qemu-devel] [RFC 0/4] virtio-mmio transport Paul Brook
[not found] ` <201112121445.27873.paul@codesourcery.com>
2011-12-12 14:51 ` Pawel Moll
2011-12-16 5:36 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323688579.2391.11.camel@hornet.cambridge.arm.com \
--to=pawel.moll@arm.com \
--cc=anthony@codemonkey.ws \
--cc=paul@codesourcery.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox