From: Asias He <asias@redhat.com>
To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Cc: Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>,
Shaohua Li <shli@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: [PATCH v2 2/3] block: Add blk_bio_map_sg() helper
Date: Mon, 18 Jun 2012 14:53:09 +0800 [thread overview]
Message-ID: <1340002390-3950-3-git-send-email-asias@redhat.com> (raw)
In-Reply-To: <1340002390-3950-1-git-send-email-asias@redhat.com>
Add a helper to map a bio to a scatterlist, modelled after
blk_rq_map_sg.
This helper is useful for any driver that wants to create
a scatterlist from its ->make_request_fn method.
Changes in v2:
- Use __blk_segment_map_sg to avoid duplicated code
- Add cocbook style function comment
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Tejun Heo <tj@kernel.org>
Cc: Shaohua Li <shli@kernel.org>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
Signed-off-by: Asias He <asias@redhat.com>
---
block/blk-merge.c | 37 +++++++++++++++++++++++++++++++++++++
include/linux/blkdev.h | 2 ++
2 files changed, 39 insertions(+)
diff --git a/block/blk-merge.c b/block/blk-merge.c
index 576b68e..e76279e 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -209,6 +209,43 @@ int blk_rq_map_sg(struct request_queue *q, struct request *rq,
}
EXPORT_SYMBOL(blk_rq_map_sg);
+/**
+ * blk_bio_map_sg - map a bio to a scatterlist
+ * @q: request_queue in question
+ * @bio: bio being mapped
+ * @sglist: scatterlist being mapped
+ *
+ * Note:
+ * Caller must make sure sg can hold bio->bi_phys_segments entries
+ *
+ * Will return the number of sg entries setup
+ */
+int blk_bio_map_sg(struct request_queue *q, struct bio *bio,
+ struct scatterlist *sglist)
+{
+ struct bio_vec *bvec, *bvprv;
+ struct scatterlist *sg;
+ int nsegs, cluster;
+ unsigned long i;
+
+ nsegs = 0;
+ cluster = blk_queue_cluster(q);
+
+ bvprv = NULL;
+ sg = NULL;
+ bio_for_each_segment(bvec, bio, i) {
+ __blk_segment_map_sg(q, bvec, sglist, &bvprv, &sg,
+ &nsegs, &cluster);
+ } /* segments in bio */
+
+ if (sg)
+ sg_mark_end(sg);
+
+ BUG_ON(bio->bi_phys_segments && nsegs > bio->bi_phys_segments);
+ return nsegs;
+}
+EXPORT_SYMBOL(blk_bio_map_sg);
+
static inline int ll_new_hw_segment(struct request_queue *q,
struct request *req,
struct bio *bio)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index ba43f40..46916af 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -884,6 +884,8 @@ extern void blk_queue_flush_queueable(struct request_queue *q, bool queueable);
extern struct backing_dev_info *blk_get_backing_dev_info(struct block_device *bdev);
extern int blk_rq_map_sg(struct request_queue *, struct request *, struct scatterlist *);
+extern int blk_bio_map_sg(struct request_queue *q, struct bio *bio,
+ struct scatterlist *sglist);
extern void blk_dump_rq_flags(struct request *, char *);
extern long nr_blockdev_pages(void);
--
1.7.10.2
next prev parent reply other threads:[~2012-06-18 6:53 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 6:53 [PATCH v2 0/3] Improve virtio-blk performance Asias He
2012-06-18 6:53 ` [PATCH 1/3] block: Introduce __blk_segment_map_sg() helper Asias He
2012-06-18 21:31 ` Tejun Heo
2012-06-19 2:02 ` Asias He
2012-06-19 18:00 ` Tejun Heo
2012-06-18 6:53 ` Asias He [this message]
2012-06-18 6:53 ` [PATCH 3/3] virtio-blk: Add bio-based IO path for virtio-blk Asias He
2012-06-18 7:46 ` Rusty Russell
2012-06-18 8:03 ` Asias He
2012-06-18 10:05 ` Rusty Russell
2012-06-18 11:14 ` Dor Laor
2012-06-18 11:39 ` Sasha Levin
2012-06-19 2:51 ` Asias He
2012-06-19 6:21 ` Dor Laor
2012-06-20 4:46 ` Asias He
2012-06-21 9:49 ` Dor Laor
2012-07-01 23:54 ` Rusty Russell
[not found] ` <87r4svxcjw.fsf@rustcorp.com.au>
2012-07-02 2:45 ` Asias He
2012-07-02 6:41 ` Rusty Russell
2012-07-03 0:39 ` Asias He
2012-07-04 2:40 ` Rusty Russell
2012-07-06 1:03 ` Asias He
2012-07-03 13:31 ` Paolo Bonzini
[not found] ` <4FF2F417.2010209@redhat.com>
2012-07-03 14:02 ` Asias He
2012-07-03 14:22 ` Ronen Hod
2012-07-03 14:28 ` Dor Laor
2012-07-04 14:10 ` Paolo Bonzini
2012-06-18 21:28 ` Tejun Heo
2012-06-19 2:39 ` Asias He
2012-06-18 10:13 ` Michael S. Tsirkin
2012-06-19 2:21 ` Asias He
2012-06-18 9:37 ` Stefan Hajnoczi
2012-06-18 10:21 ` Michael S. Tsirkin
2012-06-18 10:45 ` Stefan Hajnoczi
2012-06-19 2:30 ` Asias He
2012-06-18 9:14 ` [PATCH v2 0/3] Improve virtio-blk performance Stefan Hajnoczi
2012-06-18 9:39 ` Asias He
2012-06-18 10:58 ` Stefan Hajnoczi
2012-06-19 4:24 ` Asias He
2012-06-19 10:14 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340002390-3950-3-git-send-email-asias@redhat.com \
--to=asias@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@kernel.org \
--cc=tj@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).