From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: target-devel <target-devel@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
kernel-janitors@vger.kernel.org, kvm@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [patch -next] tcm_vhost: another strlen() off by one
Date: Sat, 14 Jul 2012 15:21:59 -0700 [thread overview]
Message-ID: <1342304519.18004.230.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20120713104547.GA31435@elgon.mountain>
On Fri, 2012-07-13 at 13:45 +0300, Dan Carpenter wrote:
> strlen() doesn't count the NUL terminator. I missed this one in the
> patches I sent yesterday.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c
> index 29850cb..ea72198 100644
> --- a/drivers/vhost/tcm_vhost.c
> +++ b/drivers/vhost/tcm_vhost.c
> @@ -1424,7 +1424,7 @@ static struct se_wwn *tcm_vhost_make_tport(
> return ERR_PTR(-EINVAL);
>
> check_len:
> - if (strlen(name) > TCM_VHOST_NAMELEN) {
> + if (strlen(name) >= TCM_VHOST_NAMELEN) {
> pr_err("Emulated %s Address: %s, exceeds"
> " max: %d\n", name, tcm_vhost_dump_proto_id(tport),
> TCM_VHOST_NAMELEN);
Applied + squashed into the initial merge commit in for-next-merge.
Thanks DanC!
--nab
prev parent reply other threads:[~2012-07-14 22:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 10:45 [patch -next] tcm_vhost: another strlen() off by one Dan Carpenter
2012-07-14 22:21 ` Nicholas A. Bellinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342304519.18004.230.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).