From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nicholas A. Bellinger" Subject: Re: [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi Date: Fri, 07 Sep 2012 12:23:03 -0700 Message-ID: <1347045783.4162.651.camel@haakon2.linux-iscsi.org> References: <1347000499-28701-1-git-send-email-nab@linux-iscsi.org> <1347000499-28701-5-git-send-email-nab@linux-iscsi.org> <504A1A32.5050705@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <504A1A32.5050705@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Paolo Bonzini Cc: Stefan Hajnoczi , kvm-devel , "Michael S. Tsirkin" , Jan Kiszka , qemu-devel , Zhi Yong Wu , Anthony Liguori , target-devel , lf-virt , Christoph Hellwig List-Id: virtualization@lists.linuxfoundation.org On Fri, 2012-09-07 at 18:00 +0200, Paolo Bonzini wrote: > Il 07/09/2012 08:48, Nicholas A. Bellinger ha scritto: > > Cc: Stefan Hajnoczi > > Cc: Zhi Yong Wu > > Cc: Michael S. Tsirkin > > Cc: Paolo Bonzini > > Signed-off-by: Nicholas Bellinger > > --- > > hw/virtio-pci.c | 2 ++ > > hw/virtio-scsi.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ > > hw/virtio-scsi.h | 1 + > > 3 files changed, 52 insertions(+), 0 deletions(-) > > Please create a completely separate device vhost-scsi-pci instead (or > virtio-scsi-tcm-pci, or something like that). It is used completely > differently from virtio-scsi-pci, it does not make sense to conflate the > two. > Ok, I need to figure out what this will involve over the next days, and will likely have some more questions for you to get a standlone vhost-scsi-pci up and running. Also just curious (question for Anthony + QEMU folks), how long can we expect the QEMU 1.3 merge window to be open..? Thanks Paolo! --nab