From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [RFC PATCH v6 74/92] kvm: x86: do not unconditionally patch the hypercall instruction during emulation Date: Tue, 13 Aug 2019 11:20:45 +0200 Message-ID: <1362cc5c-d0cd-6b7c-1151-9df3996fefa9@redhat.com> References: <20190809160047.8319-1-alazar@bitdefender.com> <20190809160047.8319-75-alazar@bitdefender.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190809160047.8319-75-alazar@bitdefender.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: =?UTF-8?Q?Adalbert_Laz=c4=83r?= , kvm@vger.kernel.org Cc: Tamas K Lengyel , Weijiang Yang , Yu C Zhang , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Jan Kiszka , =?UTF-8?Q?Samuel_Laur=c3=a9n?= , Konrad Rzeszutek Wilk , virtualization@lists.linux-foundation.org, linux-mm@kvack.org, Patrick Colp , Mathieu Tarral , Stefan Hajnoczi , =?UTF-8?Q?Mihai_Don=c8=9bu?= , Joerg Roedel List-Id: virtualization@lists.linuxfoundation.org T24gMDkvMDgvMTkgMTg6MDAsIEFkYWxiZXJ0IExhesSDciB3cm90ZToKPiBGcm9tOiBNaWhhaSBE b27Im3UgPG1kb250dUBiaXRkZWZlbmRlci5jb20+Cj4gCj4gSXQgY2FuIGhhcHBlbmVkIGZvciB1 cyB0byBlbmQgdXAgZW11bGF0aW5nIHRoZSBWTUNBTEwgaW5zdHJ1Y3Rpb24gYXMgYQo+IHJlc3Vs dCBvZiB0aGUgaGFuZGxpbmcgb2YgYW4gRVBUIHdyaXRlIGZhdWx0LiBJbiB0aGlzIHNpdHVhdGlv biwgdGhlCj4gZW11bGF0b3Igd2lsbCB0cnkgdG8gdW5jb25kaXRpb25hbGx5IHBhdGNoIHRoZSBj b3JyZWN0IGh5cGVyY2FsbCBvcGNvZGUKPiBieXRlcyB1c2luZyBlbXVsYXRvcl93cml0ZV9lbXVs YXRlZCgpLiBIb3dldmVyLCB0aGlzIGxhc3QgY2FsbCB1c2VzIHRoZQo+IGZhdWx0IEdQQSAoaWYg YXZhaWxhYmxlKSBvciB3YWxrcyB0aGUgZ3Vlc3QgcGFnZSB0YWJsZXMgYXQgUklQLAo+IG90aGVy d2lzZS4gVGhlIHRyb3VibGUgYmVnaW5zIHdoZW4gdXNpbmcgS1ZNSSwgd2hlbiB3ZSBmb3JiaWQg dGhlIHVzZSBvZgo+IHRoZSBmYXVsdCBHUEEgYW5kIGZhbGxiYWNrIHRvIHRoZSBndWVzdCBwdCB3 YWxrOiBpbiBXaW5kb3dzICg4LjEgYW5kCj4gbmV3ZXIpIHRoZSBwYWdlIHRoYXQgd2UgdHJ5IHRv IHdyaXRlIGludG8gaXMgbWFya2VkIHJlYWQtZXhlY3V0ZSBhbmQgYXMKPiBzdWNoIGVtdWxhdG9y X3dyaXRlX2VtdWxhdGVkKCkgZmFpbHMgYW5kIHdlIGluamVjdCBhIHdyaXRlICNQRiwgbGVhZGlu Zwo+IHRvIGEgZ3Vlc3QgY3Jhc2guCj4gCj4gVGhlIGZpeCBpcyByYXRoZXIgc2ltcGxlOiBjaGVj ayB0aGUgZXhpc3RpbmcgaW5zdHJ1Y3Rpb24gYnl0ZXMgYmVmb3JlCj4gZG9pbmcgdGhlIHBhdGNo aW5nLiBUaGlzIGRvZXMgbm90IGNoYW5nZSB0aGUgbm9ybWFsIEtWTSBiZWhhdmlvdXIsIGJ1dAo+ IGRvZXMgaGVscCB3aGVuIHVzaW5nIEtWTUkgYXMgd2Ugbm8gbG9uZ2VyIGluamVjdCBhIHdyaXRl ICNQRi4KCkZpeGluZyB0aGUgaHlwZXJjYWxsIGlzIGp1c3QgYW4gb3B0aW1pemF0aW9uLiAgQ2Fu IHdlIGp1c3QgaHVzaCBhbmQKcmV0dXJuIHRvIHRoZSBndWVzdCBpZiBlbXVsYXRvcl93cml0ZV9l bXVsYXRlZCByZXR1cm5zClg4NkVNVUxfUFJPUEFHQVRFX0ZBVUxUPwoKUGFvbG8KCj4gQ0M6IEpv ZXJnIFJvZWRlbCA8am9yb0A4Ynl0ZXMub3JnPgo+IFNpZ25lZC1vZmYtYnk6IE1paGFpIERvbsib dSA8bWRvbnR1QGJpdGRlZmVuZGVyLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBBZGFsYmVydCBMYXrE g3IgPGFsYXphckBiaXRkZWZlbmRlci5jb20+Cj4gLS0tCj4gIGFyY2gveDg2L2t2bS94ODYuYyB8 IDIzICsrKysrKysrKysrKysrKysrKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMCBpbnNlcnRp b25zKCspLCAzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9hcmNoL3g4Ni9rdm0veDg2 LmMgYi9hcmNoL3g4Ni9rdm0veDg2LmMKPiBpbmRleCAwNGIxZDI5MTZhMGEuLjk2NWM0ZjAxMDhl YiAxMDA2NDQKPiAtLS0gYS9hcmNoL3g4Ni9rdm0veDg2LmMKPiArKysgYi9hcmNoL3g4Ni9rdm0v eDg2LmMKPiBAQCAtNzM2MywxNiArNzM2MywzMyBAQCBpbnQga3ZtX2VtdWxhdGVfaHlwZXJjYWxs KHN0cnVjdCBrdm1fdmNwdSAqdmNwdSkKPiAgfQo+ICBFWFBPUlRfU1lNQk9MX0dQTChrdm1fZW11 bGF0ZV9oeXBlcmNhbGwpOwo+ICAKPiArI2RlZmluZSBLVk1fSFlQRVJDQUxMX0lOU05fTEVOIDMK PiArCj4gIHN0YXRpYyBpbnQgZW11bGF0b3JfZml4X2h5cGVyY2FsbChzdHJ1Y3QgeDg2X2VtdWxh dGVfY3R4dCAqY3R4dCkKPiAgewo+ICsJaW50IGVycjsKPiAgCXN0cnVjdCBrdm1fdmNwdSAqdmNw dSA9IGVtdWxfdG9fdmNwdShjdHh0KTsKPiAtCWNoYXIgaW5zdHJ1Y3Rpb25bM107Cj4gKwljaGFy IGJ1ZltLVk1fSFlQRVJDQUxMX0lOU05fTEVOXTsKPiArCWNoYXIgaW5zdHJ1Y3Rpb25bS1ZNX0hZ UEVSQ0FMTF9JTlNOX0xFTl07Cj4gIAl1bnNpZ25lZCBsb25nIHJpcCA9IGt2bV9yaXBfcmVhZCh2 Y3B1KTsKPiAgCj4gKwllcnIgPSBlbXVsYXRvcl9yZWFkX2VtdWxhdGVkKGN0eHQsIHJpcCwgYnVm LCBzaXplb2YoYnVmKSwKPiArCQkJCSAgICAgJmN0eHQtPmV4Y2VwdGlvbik7Cj4gKwlpZiAoZXJy ICE9IFg4NkVNVUxfQ09OVElOVUUpCj4gKwkJcmV0dXJuIGVycjsKPiArCj4gIAlrdm1feDg2X29w cy0+cGF0Y2hfaHlwZXJjYWxsKHZjcHUsIGluc3RydWN0aW9uKTsKPiArCWlmICghbWVtY21wKGlu c3RydWN0aW9uLCBidWYsIHNpemVvZihpbnN0cnVjdGlvbikpKQo+ICsJCS8qCj4gKwkJICogVGhl IGh5cGVyY2FsbCBpbnN0cnVjdGlvbiBpcyB0aGUgY29ycmVjdCBvbmUuIFJldHJ5Cj4gKwkJICog aXRzIGV4ZWN1dGlvbiBtYXliZSB3ZSBnb3QgaGVyZSBhcyBhIHJlc3VsdCBvZiBhbgo+ICsJCSAq IGV2ZW50IG90aGVyIHRoYW4gI1VEIHdoaWNoIGhhcyBiZWVuIHJlc29sdmVkIGluIHRoZQo+ICsJ CSAqIG1lYW4gdGltZS4KPiArCQkgKi8KPiArCQlyZXR1cm4gWDg2RU1VTF9DT05USU5VRTsKPiAg Cj4gLQlyZXR1cm4gZW11bGF0b3Jfd3JpdGVfZW11bGF0ZWQoY3R4dCwgcmlwLCBpbnN0cnVjdGlv biwgMywKPiAtCQkmY3R4dC0+ZXhjZXB0aW9uKTsKPiArCXJldHVybiBlbXVsYXRvcl93cml0ZV9l bXVsYXRlZChjdHh0LCByaXAsIGluc3RydWN0aW9uLAo+ICsJCQkJICAgICAgIHNpemVvZihpbnN0 cnVjdGlvbiksICZjdHh0LT5leGNlcHRpb24pOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IGRtX3Jl cXVlc3RfZm9yX2lycV9pbmplY3Rpb24oc3RydWN0IGt2bV92Y3B1ICp2Y3B1KQo+IAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6YXRpb24g bWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0 dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxp emF0aW9u