From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nicholas A. Bellinger" Subject: [PATCH-v2 0/3] virtio/vhost: Add checks for uninitialized VQs Date: Mon, 1 Apr 2013 23:58:21 +0000 Message-ID: <1364860704-11896-1-git-send-email-nab@linux-iscsi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: target-devel Cc: kvm-devel , "Michael S. Tsirkin" , qemu-devel , lf-virt , Anthony Liguori , Stefan Hajnoczi , Paolo Bonzini List-Id: virtualization@lists.linuxfoundation.org From: Nicholas Bellinger Hi folks, This series adds a virtio_queue_valid() for use by virtio-pci code in order to prevent opreations upon uninitialized VQs, which is currently expected to occur during seabios setup of virtio-scsi with in-flight vhost-scsi-pci device code. On the vhost side, it also adds virtio_queue_valid() sanity checks in vhost_virtqueue_[start,stop]() and vhost_verify_ring_mappings() in order to skip the same uninitialized VQs. Changes from v1: - Remove now unnecessary virtio_queue_get_num() calls in virtio-pci.c - Add virtio_queue_valid() calls in vhost_virtqueue_[start,stop]() Please review. --nab Michael S. Tsirkin (1): virtio: add API to check that ring is setup Nicholas Bellinger (2): virtio-pci: Add virtio_queue_valid checks ahead of virtio_queue_get_num vhost: Skip uninitialized VQs in vhost_virtqueue_[start,stop] hw/vhost.c | 12 ++++++++++++ hw/virtio-pci.c | 34 +++++++++++++++------------------- hw/virtio.c | 5 +++++ hw/virtio.h | 1 + 4 files changed, 33 insertions(+), 19 deletions(-) -- 1.7.2.5