virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Pawel Moll <pawel.moll@arm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "KONRAD Frédéric" <fred.konrad@greensocs.com>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>
Subject: Re: what should a virtio-mmio transport without a backend look like?
Date: Fri, 21 Jun 2013 17:47:10 +0100	[thread overview]
Message-ID: <1371833230.3155.19.camel@hornet> (raw)
In-Reply-To: <CAFEAcA9SM7K=-UFAkFOzRX0jcc5yJj6jAw4QFhWwC8VBO8SggA@mail.gmail.com>

On Fri, 2013-06-21 at 17:41 +0100, Peter Maydell wrote:
> On 21 June 2013 17:02, Christopher Covington <cov@codeaurora.org> wrote:
> > Would using CONFIG_VIRTIO_MMIO_CMDLINE_DEVICES enumeration
> > instead of device tree be any easier?
> 
> My general view is that the kernel command line is
> the user's to manipulate, and that QEMU shouldn't
> touch it at all (just pass it through). (Conversely,
> QEMU shouldn't require the user to specify odd
> kernel command line arguments in order to make things
> work.)

I couldn't agree more. Command line is for the user and user only. And
the mention config option is optional ;-) (and, interestingly enough it
wasn't there in the original version of the driver).

> As it happens, if you use the command line to specify
> a virtio device it doesn't make the same complaint about
> bad magic number as if you specify it via dtb, but that
> should probably be fixed in the kernel :-)

I don't really see how this would be possible - the "complaining code"
is just a normal platform device probe function. And whether specified
in the command line or in the tree, it's the same - platform - device.

Are you sure you haven't misspelled the parameter name or something in
the definition syntax? ;-)

Paweł


_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2013-06-21 16:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAFEAcA9qCUQLZho8wJvewYJ0AEhDBc37_LpZWs8XBV1U7RVZgA@mail.gmail.com>
2013-06-20 11:08 ` what should a virtio-mmio transport without a backend look like? Pawel Moll
2013-06-20 12:58   ` Christopher Covington
2013-06-21 15:23     ` Peter Maydell
2013-06-21 16:02       ` Christopher Covington
2013-06-21 16:41         ` Peter Maydell
2013-06-21 16:47           ` Pawel Moll [this message]
2013-06-21 17:01             ` Peter Maydell
2013-06-21 18:01               ` Christopher Covington
2013-06-21 18:28                 ` Peter Maydell
2013-06-21 18:45                   ` Christopher Covington
2013-06-22 10:51                     ` Peter Maydell
2013-06-24 12:26                       ` Christopher Covington
2013-06-24 12:57                         ` Peter Maydell
2013-06-21 20:13                   ` Paolo Bonzini
2013-07-01  0:07   ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371833230.3155.19.camel@hornet \
    --to=pawel.moll@arm.com \
    --cc=fred.konrad@greensocs.com \
    --cc=peter.maydell@linaro.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).