From: Ian Campbell <Ian.Campbell@citrix.com>
To: Joe Perches <joe@perches.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
xen-devel@lists.xensource.com, Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"virtualization@lists.osdl.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH next] xen: Convert printks to pr_<level>
Date: Fri, 28 Jun 2013 12:12:58 +0100 [thread overview]
Message-ID: <1372417978.8976.123.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <1372414901.2060.44.camel@joe-AO722>
On Fri, 2013-06-28 at 03:21 -0700, Joe Perches wrote:
> Convert printks to pr_<level> (excludes printk(KERN_DEBUG...)
> to be more consistent throughout the xen subsystem.
>
> Add pr_fmt with KBUILD_MODNAME or "xen:" KBUILD_MODNAME
> Coalesce formats and add missing word spaces
> Add missing newlines
> Align arguments and reflow to 80 columns
> Remove DRV_NAME from formats as pr_fmt adds the same content
>
> This does change some of the prefixes of these messages
> but it also does make them more consistent.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>
> On Fri, 2013-06-28 at 09:02 +0100, Wei Liu wrote:
> > Do you also need to replace other printk occurences in xen-netback
> > directory, say, interface.c and xenbus.c?
>
> Well, I don't _need_ to but if you want it
I think Wei just mean drivers/net/xen-blkback/{interface.c,xenbus.c} in
addition to the netback.c you were patching in your previous patch.
> this is what I suggest.
Wow ;-)
> drivers/xen/balloon.c | 6 +++--
> drivers/xen/cpu_hotplug.c | 6 +++--
> drivers/xen/events.c | 23 +++++++++---------
> drivers/xen/evtchn.c | 6 +++--
> drivers/xen/gntalloc.c | 6 +++--
> drivers/xen/gntdev.c | 8 ++++---
> drivers/xen/grant-table.c | 17 +++++++-------
> drivers/xen/manage.c | 23 +++++++++---------
> drivers/xen/mcelog.c | 36 +++++++++++------------------
> drivers/xen/pcpu.c | 12 +++++-----
> drivers/xen/privcmd.c | 4 +++-
> drivers/xen/swiotlb-xen.c | 12 ++++++----
> drivers/xen/tmem.c | 10 ++++----
> drivers/xen/xen-acpi-cpuhotplug.c | 2 ++
> drivers/xen/xen-acpi-memhotplug.c | 2 ++
> drivers/xen/xen-acpi-pad.c | 2 ++
> drivers/xen/xen-acpi-processor.c | 25 ++++++++++----------
> drivers/xen/xen-balloon.c | 6 +++--
> drivers/xen/xen-pciback/conf_space_header.c | 16 ++++++-------
> drivers/xen/xen-pciback/pci_stub.c | 25 +++++++++-----------
> drivers/xen/xen-pciback/pciback_ops.c | 9 +++++---
> drivers/xen/xen-pciback/vpci.c | 10 ++++----
> drivers/xen/xen-pciback/xenbus.c | 8 ++++---
> drivers/xen/xen-selfballoon.c | 11 ++++-----
> drivers/xen/xenbus/xenbus_comms.c | 13 ++++++-----
> drivers/xen/xenbus/xenbus_dev_backend.c | 4 +++-
> drivers/xen/xenbus/xenbus_dev_frontend.c | 4 +++-
> drivers/xen/xenbus/xenbus_probe.c | 30 +++++++++++-------------
> drivers/xen/xenbus/xenbus_probe_backend.c | 8 ++++---
> drivers/xen/xenbus/xenbus_probe_frontend.c | 35 ++++++++++++++--------------
> drivers/xen/xenbus/xenbus_xs.c | 22 ++++++++----------
> drivers/xen/xencomm.c | 2 ++
> drivers/xen/xenfs/super.c | 4 +++-
> include/xen/hvm.h | 4 ++--
> 34 files changed, 215 insertions(+), 196 deletions(-)
next prev parent reply other threads:[~2013-06-28 11:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 4:57 [PATCH next] xen: Use more current logging styles Joe Perches
2013-06-28 7:59 ` Ian Campbell
2013-07-01 20:31 ` David Miller
2013-06-28 8:02 ` Wei Liu
2013-06-28 10:21 ` [PATCH next] xen: Convert printks to pr_<level> Joe Perches
2013-06-28 10:36 ` Wei Liu
2013-06-28 11:31 ` Joe Perches
2013-06-28 11:12 ` Ian Campbell [this message]
2013-06-28 13:11 ` [PATCH next] xen: Use more current logging styles Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372417978.8976.123.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=jeremy@goop.org \
--cc=joe@perches.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox