virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Amos Kong <akong@redhat.com>
To: virtualization@lists.linux-foundation.org
Cc: amit.shah@redhat.com, kvm@vger.kernel.org
Subject: [PATCH 0/2] fix stuck in catting hwrng attributes
Date: Wed, 10 Sep 2014 17:07:05 +0800	[thread overview]
Message-ID: <1410340027-15373-1-git-send-email-akong@redhat.com> (raw)

If we read hwrng by long-running dd process, it takes too much cpu time.
When we check hwrng attributes from sysfs by cat, it gets stuck.
The problem can only be reproduced with non-smp guest with slow backend.

This patchset changed hwrng core to always delay 10 jiffies, cat process
have chance to execute protected code, the problem is resolved.

Thanks.

Amos Kong (2):
  virtio-rng cleanup: move some code out of mutex protection
  virtio-rng: fix stuck in catting hwrng attributes

 drivers/char/hw_random/core.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

-- 
1.9.3

             reply	other threads:[~2014-09-10  9:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-10  9:07 Amos Kong [this message]
2014-09-10  9:07 ` [PATCH 1/2] virtio-rng cleanup: move some code out of mutex protection Amos Kong
2014-09-11  6:07   ` Amit Shah
2014-09-10  9:07 ` [PATCH 2/2] virtio-rng: fix stuck in catting hwrng attributes Amos Kong
2014-09-11  6:08   ` Amit Shah
2014-09-14  1:16     ` Amos Kong
2014-09-11 11:38   ` Rusty Russell
2014-09-13 17:12     ` Amos Kong
2014-09-14  1:12       ` Amos Kong
2014-09-14  2:25         ` Amos Kong
2014-09-15 16:48           ` Radim Krčmář
2014-09-16  0:50             ` Amos Kong
2014-09-16 15:35         ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410340027-15373-1-git-send-email-akong@redhat.com \
    --to=akong@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).