virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Amos Kong <akong@redhat.com>
To: virtualization@lists.linux-foundation.org
Cc: amit.shah@redhat.com, kvm@vger.kernel.org
Subject: [PATCH 2/2] virtio-rng: fix stuck in catting hwrng attributes
Date: Wed, 10 Sep 2014 17:07:07 +0800	[thread overview]
Message-ID: <1410340027-15373-3-git-send-email-akong@redhat.com> (raw)
In-Reply-To: <1410340027-15373-1-git-send-email-akong@redhat.com>

When I check hwrng attributes in sysfs, cat process always gets
stuck if guest has only 1 vcpu and uses a slow rng backend.

Currently we check if there is any tasks waiting to be run on
current cpu in rng_dev_read() by need_resched(). But need_resched()
doesn't work because rng_dev_read() is executing in user context.

This patch removed need_resched() and increase delay to 10 jiffies,
then other tasks can have chance to execute protected code.
Delaying 1 jiffy also works, but 10 jiffies is safer.

Signed-off-by: Amos Kong <akong@redhat.com>
---
 drivers/char/hw_random/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index c591d7e..b5d1b6f 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -195,8 +195,7 @@ static ssize_t rng_dev_read(struct file *filp, char __user *buf,
 
 		mutex_unlock(&rng_mutex);
 
-		if (need_resched())
-			schedule_timeout_interruptible(1);
+		schedule_timeout_interruptible(10);
 
 		if (signal_pending(current)) {
 			err = -ERESTARTSYS;
-- 
1.9.3

  parent reply	other threads:[~2014-09-10  9:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-10  9:07 [PATCH 0/2] fix stuck in catting hwrng attributes Amos Kong
2014-09-10  9:07 ` [PATCH 1/2] virtio-rng cleanup: move some code out of mutex protection Amos Kong
2014-09-11  6:07   ` Amit Shah
2014-09-10  9:07 ` Amos Kong [this message]
2014-09-11  6:08   ` [PATCH 2/2] virtio-rng: fix stuck in catting hwrng attributes Amit Shah
2014-09-14  1:16     ` Amos Kong
2014-09-11 11:38   ` Rusty Russell
2014-09-13 17:12     ` Amos Kong
2014-09-14  1:12       ` Amos Kong
2014-09-14  2:25         ` Amos Kong
2014-09-15 16:48           ` Radim Krčmář
2014-09-16  0:50             ` Amos Kong
2014-09-16 15:35         ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410340027-15373-3-git-send-email-akong@redhat.com \
    --to=akong@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).